Skip to content

[HOLD for payment 2024-06-20] Remove unnecessary WorkspaceSwitcherButton component renders #43352

Closed

Description

@Julesssss

Problem

Mykhailo located a performance improvement within WorkspaceSwitcherButton where we can remove some unnecessary re-renders.

Discussed here in Slack

Solution

As explained by Mykhailo:

Use React.memo for the component to rerender only when necessary. Do not destruct object and use it directly.

Issue OwnerCurrent Issue Owner: @Julesssss

Activity

  1. rezkiy37 commented on Jun 10, 2024

    @rezkiy37
    Contributor

    Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

  2. rezkiy37 commented on Jun 10, 2024

    @rezkiy37
    Contributor

    I've opened the PR for review.

  3. self-assigned this
    on Jun 10, 2024
  4. deleted a comment from melvin-bot on Jun 10, 2024
  5. 4 remaining items

  6. changed the title [-]Remove unnecessary WorkspaceSwitcherButton component renders[/-] [+][HOLD for payment 2024-06-20] Remove unnecessary WorkspaceSwitcherButton component renders[/+] on Jun 13, 2024
  7. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  8. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-20. 🎊

    For reference, here are some details about the assignees on this issue:

  9. melvin-bot commented on Jun 20, 2024

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @anmurali you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  10. melvin-bot commented on Jun 20, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@anmurali)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. anmurali commented on Jun 21, 2024

    @anmurali

    Payment Summary

  12. JmillsExpensify commented on Jul 20, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions