You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-28] [$250] [Search v1] - Selected expense at the bottom of the list is not revealed when selected via keyboard #43362
Version Number: 1.4.81-1 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:
Action Performed:
Precondition:
Account has many expenses.
Go to staging.new.expensify.com
Go to Search.
Go to Shared.
Navigate to the expense at the bottom of the list via keyboard.
Expected Result:
The list will scroll to reveal the selected expense when the list reaches the bottom.
Actual Result:
The selected expense at the bottom of the list is not revealed when selected via keyboard.
The list scrolls up and down when selecting the expenses at the bottom.
NOTE : To easily reproduce the bug have lots of multiple expenses reports
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott / @Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Link to the PR: It's not a regression, SelectionList was not compatible with the new Search.
Link to comment: N/A
Link to discussion: N/A
Determine if we should create a regression test for this bug: Yes
Regression Test Proposal
1. Open App
2. Go to Search
3. Use keyboard to navigate over search list items : use Tab key, and also up and down keyboard keys
4. Verify the focus and scroll is working correctly
Activity
melvin-bot commentedon Jun 10, 2024
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 10, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jun 10, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
m-natarajan commentedon Jun 10, 2024
@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
42 remaining items
melvin-bot commentedon Jun 21, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Christinadobrzyn commentedon Jun 28, 2024
Payouts due:
@fedirjh do we need a regression test?
Christinadobrzyn commentedon Jul 1, 2024
Nudge @fedirjh about these questions - #43362 (comment)
fedirjh commentedon Jul 2, 2024
BugZero Checklist:
SelectionListwas not compatible with the newSearch.Regression Test Proposal
fedirjh commentedon Jul 2, 2024
@Christinadobrzyn I will request a payment on new Dot.
Christinadobrzyn commentedon Jul 2, 2024
Thanks @fedirjh!
regression test here - https://github.com/Expensify/Expensify/issues/409709
Payment summary for payment through NewDot here - #43362 (comment)
Closing!
JmillsExpensify commentedon Jul 2, 2024
$250 approved for @fedirjh