Skip to content

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Search v1] Sorting on mobile is random #43376

Closed

Description

@luacmartins

Coming from this thread, the sorting order for the expenses page on mobile seems random. It should be sorted by descending chronological order.

Issue OwnerCurrent Issue Owner: @johncschuster

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 10, 2024
  2. self-assigned this
    on Jun 10, 2024
  3. melvin-bot commented on Jun 10, 2024

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. moved this to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collecton Jun 10, 2024
  5. luacmartins commented on Jun 10, 2024

    @luacmartins
    ContributorAuthor

    @adamgrzybowski can you comment on this issue so I can assign it to you please?

  6. melvin-bot commented on Jun 10, 2024

    @melvin-bot

    Current assignee @luacmartins is eligible for the DeployBlockerCash assigner, not assigning anyone new.

  7. 4 remaining items

  8. moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collecton Jun 10, 2024
  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 11, 2024
  10. changed the title [-][Search v1] Sorting on mobile is random[/-] [+][HOLD for payment 2024-06-18] [Search v1] Sorting on mobile is random[/+] on Jun 11, 2024
  11. melvin-bot commented on Jun 11, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jun 11, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-18. 🎊

  13. melvin-bot commented on Jun 11, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
    • [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@luacmartins] Determine if we should create a regression test for this bug.
    • [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. changed the title [-][HOLD for payment 2024-06-18] [Search v1] Sorting on mobile is random[/-] [+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Search v1] Sorting on mobile is random[/+] on Jun 13, 2024
  15. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-20. 🎊

  16. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
    • [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@luacmartins] Determine if we should create a regression test for this bug.
    • [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions