Skip to content

[HOLD for payment 2024-07-10] [Search v1] - Scanning expense displays 0.00 in Total column and the Merchant column is blank #43474

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.81-8
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit a scan expense.
  4. While the receipt is scanning, go to Search.

Expected Result:

The scanning expense will display "Scanning" in Merchant and Total column, similar to transaction thread.

Actual Result:

The scanning expense displays 0.00 in Total column, and the Merchant column is blank.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6509220_1718101572011.20240611_182221.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 11, 2024
  2. melvin-bot commented on Jun 11, 2024

    @melvin-bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jun 11, 2024

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Jun 11, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Jun 11, 2024

    @m-natarajan
    Author

    @garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. m-natarajan commented on Jun 11, 2024

    @m-natarajan
    Author

    We think that this bug might be related to #wave-collect - Release 1

  7. etCoderDysto commented on Jun 11, 2024

    @etCoderDysto
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Scanning expenses display 0.00 in the Total column, and the Merchant column is blank.

    What is the root cause of that problem?

    transactionItem.formattedMerchantand transactionItem.formattedMerchant are displayed without checking if a scan request state is "SCANNING". There is no state property on transactionItem.receipt for TotalCell and MerchantCell. Therefore we can't determine if the scan transaction state is "SCANNING" following the same pattern used on MoneyRequestView. This is because BE doesn't return transaction.receipt.state value on a transaction object for Search query, but it does for RequestMoney query.

    Search query BE response
    Screenshot 2024-06-12 at 5 21 29 in the afternoon

    RequestMoney query BE response
    Screenshot 2024-06-12 at 5 22 16 in the afternoon

    What changes do you think we should make in order to solve the problem?

    • Update the BE to return a transaction object that has transactionItem.receipt.state value for Search query
    • Then check a scan transaction state following the same pattern as MoneyRequestView
      if (TransactionUtils.hasReceipt(transaction) && TransactionUtils.isReceiptBeingScanned(transaction)) {
      merchantTitle = translate('iou.receiptStatusTitle');
      amountTitle = translate('iou.receiptStatusTitle');
    • Display transactionItem.formattedTotal and transactionItem.formattedMerchant, if scan transaction stat is 'SACNNING' or display 'Scanning...' if the sate is not 'SCANNING'

    What alternative solutions did you explore? (Optional)

    N/A

  8. 61 remaining items

  9. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-10. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mollfpr requires payment through NewDot Manual Requests
    • @etCoderDysto requires payment (Needs manual offer from BZ)
  10. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
    • [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mollfpr] Determine if we should create a regression test for this bug.
    • [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. melvin-bot commented on Jul 10, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@garrettmknight)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. garrettmknight commented on Jul 10, 2024

    @garrettmknight
    Contributor

    Payment Summary:

    @etCoderDysto offer out to you in Upwork

  13. etCoderDysto commented on Jul 10, 2024

    @etCoderDysto
    Contributor

    I have accepted the offer. Thank you!

  14. garrettmknight commented on Jul 11, 2024

    @garrettmknight
    Contributor

    Contributor paid, dropping to weekly for reveiwer to request.

  15. mollfpr commented on Jul 11, 2024

    @mollfpr
    Contributor

    [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
    [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    No offending PR was found.

    [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    The regression step should be enough.

    [@mollfpr] Determine if we should create a regression test for this bug.
    [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    1. Go to workspace chat.
    2. Submit a scan expense.
    3. While the receipt is scanning, go to Search.
    4. Verify that the 'Scanning...' message is displayed on the Merchant and Total fields
    5. After the receipt finishes scanning return back to the Search page
    6. Verify that the scan result is displayed on the Merchant and Total fields instead of the 'Scanning...' message
    7. 👍 or 👎
  16. JmillsExpensify commented on Jul 11, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @mollfpr

  17. luacmartins commented on Jul 11, 2024

    @luacmartins
    Contributor

    We'll add tests as part of the project wrap up, so no need to do that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions