You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-10] [Search v1] - Scanning expense displays 0.00 in Total column and the Merchant column is blank #43474
Version Number: 1.4.81-8 Reproducible in staging?: y Reproducible in production?: new feature If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Submit a scan expense.
While the receipt is scanning, go to Search.
Expected Result:
The scanning expense will display "Scanning" in Merchant and Total column, similar to transaction thread.
Actual Result:
The scanning expense displays 0.00 in Total column, and the Merchant column is blank.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Please re-state the problem that we are trying to solve in this issue.
Scanning expenses display 0.00 in the Total column, and the Merchant column is blank.
What is the root cause of that problem?
transactionItem.formattedMerchantand transactionItem.formattedMerchant are displayed without checking if a scan request state is "SCANNING". There is no state property on transactionItem.receipt for TotalCell and MerchantCell. Therefore we can't determine if the scan transaction state is "SCANNING" following the same pattern used on MoneyRequestView. This is because BE doesn't return transaction.receipt.state value on a transaction object for Search query, but it does for RequestMoney query.
Search query BE response
RequestMoney query BE response
What changes do you think we should make in order to solve the problem?
Update the BE to return a transaction object that has transactionItem.receipt.state value for Search query
Then check a scan transaction state following the same pattern as MoneyRequestView
Display transactionItem.formattedTotal and transactionItem.formattedMerchant, if scan transaction stat is 'SACNNING' or display 'Scanning...' if the sate is not 'SCANNING'
What alternative solutions did you explore? (Optional)
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
No offending PR was found.
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
The regression step should be enough.
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Go to workspace chat.
Submit a scan expense.
While the receipt is scanning, go to Search.
Verify that the 'Scanning...' message is displayed on the Merchant and Total fields
After the receipt finishes scanning return back to the Search page
Verify that the scan result is displayed on the Merchant and Total fields instead of the 'Scanning...' message
Activity
melvin-bot commentedon Jun 11, 2024
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 11, 2024
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jun 11, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
m-natarajan commentedon Jun 11, 2024
@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
m-natarajan commentedon Jun 11, 2024
We think that this bug might be related to #wave-collect - Release 1
etCoderDysto commentedon Jun 11, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Scanning expenses display 0.00 in the Total column, and the Merchant column is blank.
What is the root cause of that problem?
transactionItem.formattedMerchantandtransactionItem.formattedMerchantare displayed without checking if a scan request state is "SCANNING". There is nostateproperty ontransactionItem.receiptfor TotalCell and MerchantCell. Therefore we can't determine if the scan transaction state is "SCANNING" following the same pattern used on MoneyRequestView. This is because BE doesn't returntransaction.receipt.statevalue on a transaction object forSearchquery, but it does forRequestMoneyquery.Search query BE response

RequestMoney query BE response

What changes do you think we should make in order to solve the problem?
transactionItem.receipt.statevalue forSearchqueryApp/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 195 to 197 in 4f2901f
transactionItem.formattedTotalandtransactionItem.formattedMerchant, if scan transaction stat is 'SACNNING' or display 'Scanning...' if the sate is not 'SCANNING'What alternative solutions did you explore? (Optional)
N/A
61 remaining items
melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 3, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Jul 10, 2024
Payment Summary
Upwork Job
BugZero Checklist (@garrettmknight)
garrettmknight commentedon Jul 10, 2024
Payment Summary:
@etCoderDysto offer out to you in Upwork
etCoderDysto commentedon Jul 10, 2024
I have accepted the offer. Thank you!
garrettmknight commentedon Jul 11, 2024
Contributor paid, dropping to weekly for reveiwer to request.
mollfpr commentedon Jul 11, 2024
No offending PR was found.
The regression step should be enough.
JmillsExpensify commentedon Jul 11, 2024
$250 approved for @mollfpr
luacmartins commentedon Jul 11, 2024
We'll add tests as part of the project wrap up, so no need to do that now.