You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Web - Subscription - No offline indicator on subscription page #43558
Version Number: 1.4.82-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[@akinwale] The PR that introduced the bug has been identified. Link to the PR:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Not a regression.
[@akinwale] Determine if we should create a regression test for this bug.
[@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
changed the title [-][HOLD for payment 2024-07-02] [$250] Web - Subscription - No offline indicator on subscription page[/-][+][HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Web - Subscription - No offline indicator on subscription page[/+]on Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@akinwale] The PR that introduced the bug has been identified. Link to the PR:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@akinwale] Determine if we should create a regression test for this bug.
[@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jun 12, 2024
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Jun 12, 2024
We think that this bug might be related to #wave-collect - Release 2
lanitochka17 commentedon Jun 12, 2024
@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
cretadn22 commentedon Jun 12, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
No offline indicator on subscription page
What is the root cause of that problem?
In
SubcriptionSettingsPagecomponent we useScreenWrapperbut we don't includeshouldShowOfflineIndicatorInWideScreenApp/src/pages/settings/Subscription/SubscriptionSettingsPage.tsx
Line 37 in 4d8d46c
What changes do you think we should make in order to solve the problem?
Let's add
shouldShowOfflineIndicatorInWideScreento this placeBonus point 1: Consider to add other props like includeSafeAreaPaddingBottom, style, offlineIndicatorStyle like other pages
App/src/pages/workspace/tags/WorkspaceTagsPage.tsx
Lines 301 to 310 in 4d8d46c
Bonus point 2: Consider to incorporate AccessOrNotFoundWrapper outside of the SubscriptionSettingsPage like other pages
App/src/pages/workspace/tags/WorkspaceTagsPage.tsx
Line 296 in 4d8d46c
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Jun 17, 2024
@kevinksullivan Huh... This is 4 days overdue. Who can take care of this?
kevinksullivan commentedon Jun 17, 2024
Putting into collect as this is focused on subscription page.
melvin-bot commentedon Jun 17, 2024
Job added to Upwork: https://www.upwork.com/jobs/~010b0cd5636fae177d
30 remaining items
kevinksullivan commentedon Jul 3, 2024
Paid @cretadn22 , waiting on checklist to pay @akinwale
akinwale commentedon Jul 3, 2024
Not a regression.
Regression Test Steps
Do we agree 👍 or 👎?
akinwale commentedon Jul 3, 2024
@kevinksullivan Done!
[-][HOLD for payment 2024-07-02] [$250] Web - Subscription - No offline indicator on subscription page[/-][+][HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Web - Subscription - No offline indicator on subscription page[/+]melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 3, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
kevinksullivan commentedon Jul 15, 2024
waiting on checklist, asked about it here
https://expensify.slack.com/archives/C02NK2DQWUX/p1721067253383449?thread_ts=1720555683.892599&cid=C02NK2DQWUX
akinwale commentedon Jul 15, 2024
Completed the checklist here: #43558 (comment)
kevinksullivan commentedon Jul 15, 2024
All set