Skip to content

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Expensify personal - Users are able to create threads in the "System" DM chat #43562

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.82-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #41343

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new Gmail account
  3. Go through onboarding flow
  4. Go to Expensify chat
  5. Right click on any message from Expensify > Reply in thread
  6. Wait for the composer in thread to disappear
  7. Click on chat header > Notification preferences
  8. Change to other preference

Expected Result:

In Step 5, app should disable reply in thread to Expensify message

Actual Result:

In Step 5, user can reply in thread to Expensify message. Then the composer disappears after replying in thread (Step 6)
In Step 8, after changing notification preference in thread message with Expensify, the preference reverts to "Immediately"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6510129_1718154038828.20240612_085358.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01aaf20e189bef2fa2
  • Upwork Job ID: 1805918670583601550
  • Last Price Increase: 2024-06-26
  • Automatic offers:
    • hoangzinh | Reviewer | 102966604
    • c3024 | Contributor | 102966605
Issue OwnerCurrent Issue Owner: @muttmuure

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 12, 2024
  2. melvin-bot commented on Jun 12, 2024

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Jun 12, 2024

    @lanitochka17
    Author

    @muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. melvin-bot commented on Jun 17, 2024

    @melvin-bot

    @muttmuure Huh... This is 4 days overdue. Who can take care of this?

  5. muttmuure commented on Jun 18, 2024

    @muttmuure
    Contributor

    Not overdue

  6. c3024 commented on Jun 23, 2024

    @c3024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    A user can reply to a thread for messages in chat with Expensify by right clicking on a report action in the chat.

    What is the root cause of that problem?

    There should be no Reply in thread and some other options in the right click context menu action popover.

    Incidentally, the MiniReportActionContextMenu that appears on hovering the report action, however, does not show these options.

    miniActions.mov

    That is because we pass disabledActions here to the MiniReportActionContextMenu

    disabledActions={!ReportUtils.canWriteInReport(report) ? RestrictedReadOnlyContextMenuActions : []}

    but we do not pass them here to the right click report action context menu

    The disabledActions include these here

    const restrictedReadOnlyActions: TranslationPaths[] = [
    'common.download',
    'reportActionContextMenu.replyInThread',
    'reportActionContextMenu.editAction',
    'reportActionContextMenu.joinThread',
    'reportActionContextMenu.deleteAction',
    ];
    const RestrictedReadOnlyContextMenuActions: ContextMenuAction[] = ContextMenuActions.filter(
    (action) => 'textTranslateKey' in action && restrictedReadOnlyActions.includes(action.textTranslateKey),
    );

    What changes do you think we should make in order to solve the problem?

    Pass the disabledActions here


    similar to this
    disabledActions={!ReportUtils.canWriteInReport(report) ? RestrictedReadOnlyContextMenuActions : []}

    Once we fix this a thread cannot be started and the other issue of changing notification preference does not exist anymore.
    Additionally in the other issue, the notification preference changes optimistically when we select another option but backend returns a 404 error later saying report not found so the notification preference gets reset.

    What alternative solutions did you explore? (Optional)

  7. melvin-bot commented on Jun 24, 2024

    @melvin-bot

    @muttmuure Huh... This is 4 days overdue. Who can take care of this?

  8. 48 remaining items

  9. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@hoangzinh / @c3024] The PR that introduced the bug has been identified. Link to the PR:
    • [@hoangzinh / @c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@hoangzinh / @c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@hoangzinh / @c3024] Determine if we should create a regression test for this bug.
    • [@hoangzinh / @c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  10. melvin-bot commented on Jul 19, 2024

    @melvin-bot

    @hoangzinh, @marcaaron, @muttmuure, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  11. marcaaron commented on Jul 23, 2024

    @marcaaron
    Contributor

    Are we blocked on anything here?

  12. c3024 commented on Jul 23, 2024

    @c3024
    Contributor

    Nope. Awaiting payment from @muttmuure since 17-Jul. Automation incorrectly added another date.

  13. melvin-bot commented on Jul 23, 2024

    @melvin-bot

    @hoangzinh, @marcaaron, @muttmuure, @c3024 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  14. hoangzinh commented on Jul 24, 2024

    @hoangzinh
    Contributor

    BugZero Checklist:

    • The PR that introduced the bug has been identified. Link to the PR: Support read only messages #40010
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/40010/files#r1689630389
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug: ✅ Yes we should
  15. hoangzinh commented on Jul 24, 2024

    @hoangzinh
    Contributor

    Regression Test Proposal

    Web/Desktop

    1. Sign in to an account that has Expensify (DM) chat
    2. Right-click on any message to open the context action menu.
    3. Verify that the Reply in thread and Join thread options are not displayed

    mWeb/Native apps

    1. Sign in to an account that has Expensify (DM) chat
    2. Tap and hold on any message to open the context action menu.
    3. Verify that the Reply in thread and Join thread options are not displayed

    Do we agree 👍 or 👎

  16. marcaaron commented on Jul 25, 2024

    @marcaaron
    Contributor

    LGTM

  17. muttmuure commented on Jul 25, 2024

    @muttmuure
    Contributor

    All paid up

  18. moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collecton Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions