You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Expensify personal - Users are able to create threads in the "System" DM chat #43562
Version Number: 1.4.82-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Right click on any message from Expensify > Reply in thread
Wait for the composer in thread to disappear
Click on chat header > Notification preferences
Change to other preference
Expected Result:
In Step 5, app should disable reply in thread to Expensify message
Actual Result:
In Step 5, user can reply in thread to Expensify message. Then the composer disappears after replying in thread (Step 6)
In Step 8, after changing notification preference in thread message with Expensify, the preference reverts to "Immediately"
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Once we fix this a thread cannot be started and the other issue of changing notification preference does not exist anymore.
Additionally in the other issue, the notification preference changes optimistically when we select another option but backend returns a 404 error later saying report not found so the notification preference gets reset.
What alternative solutions did you explore? (Optional)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@hoangzinh / @c3024] The PR that introduced the bug has been identified. Link to the PR:
[@hoangzinh / @c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hoangzinh / @c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hoangzinh / @c3024] Determine if we should create a regression test for this bug.
[@hoangzinh / @c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug: ✅ Yes we should
Activity
melvin-bot commentedon Jun 12, 2024
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Jun 12, 2024
@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
melvin-bot commentedon Jun 17, 2024
@muttmuure Huh... This is 4 days overdue. Who can take care of this?
muttmuure commentedon Jun 18, 2024
Not overdue
c3024 commentedon Jun 23, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
A user can reply to a thread for messages in chat with Expensify by right clicking on a report action in the chat.
What is the root cause of that problem?
There should be no
Reply in threadand some other options in the right click context menu action popover.Incidentally, the
MiniReportActionContextMenuthat appears on hovering the report action, however, does not show these options.miniActions.mov
That is because we pass
disabledActionshere to theMiniReportActionContextMenuApp/src/pages/home/report/ReportActionItem.tsx
Line 888 in 0176052
but we do not pass them here to the right click report action context menu
App/src/pages/home/report/ReportActionItem.tsx
Line 355 in 0176052
The
disabledActionsinclude these hereApp/src/pages/home/report/ContextMenu/ContextMenuActions.tsx
Lines 553 to 563 in 0176052
What changes do you think we should make in order to solve the problem?
Pass the
disabledActionshereApp/src/pages/home/report/ReportActionItem.tsx
Line 355 in 0176052
similar to this
App/src/pages/home/report/ReportActionItem.tsx
Line 888 in 0176052
Once we fix this a thread cannot be started and the other issue of changing notification preference does not exist anymore.
Additionally in the other issue, the notification preference changes optimistically when we select another option but backend returns a 404 error later saying report not found so the notification preference gets reset.
What alternative solutions did you explore? (Optional)
melvin-bot commentedon Jun 24, 2024
@muttmuure Huh... This is 4 days overdue. Who can take care of this?
48 remaining items
melvin-bot commentedon Jul 15, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Jul 19, 2024
@hoangzinh, @marcaaron, @muttmuure, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!
marcaaron commentedon Jul 23, 2024
Are we blocked on anything here?
c3024 commentedon Jul 23, 2024
Nope. Awaiting payment from @muttmuure since 17-Jul. Automation incorrectly added another date.
melvin-bot commentedon Jul 23, 2024
@hoangzinh, @marcaaron, @muttmuure, @c3024 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
hoangzinh commentedon Jul 24, 2024
BugZero Checklist:
hoangzinh commentedon Jul 24, 2024
Regression Test Proposal
Web/Desktop
Reply in threadandJoin threadoptions are not displayedmWeb/Native apps
Reply in threadandJoin threadoptions are not displayedDo we agree 👍 or 👎
marcaaron commentedon Jul 25, 2024
LGTM
muttmuure commentedon Jul 25, 2024
All paid up