Skip to content

[$250] Chats - User remains on LHN page after onboarding flow completed #43564

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.82-0
Reproducible in staging?: Y
Reproducible in production?: Y
Found when validating PR : #41343
Email or phone of affected tester (no customers): Hohovemgo+oma20@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Issue found when executing PR #41343

Action Performed:

Precondition: user should be Signed Out

  1. Open app
  2. Write any email with public domain which was not user for registration before
  3. Click on Continue button
  4. Click on Join button
  5. Select any onboarding option
  6. Complete the onboarding flow

Expected Result:

User should be redirected either to the Concierge chat or Expensify persona

Actual Result:

User remains on LHN page after onboarding flow completed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6510287_1718171301900.RPReplay_Final1718165520.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0170226485ccb489be
  • Upwork Job ID: 1802805545916133888
  • Last Price Increase: 2024-06-17
Issue OwnerCurrent Issue Owner: @hoangzinh

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 12, 2024
  2. melvin-bot commented on Jun 12, 2024

    @melvin-bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. cretadn22 commented on Jun 12, 2024

    @cretadn22
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    User remains on LHN page after onboarding flow completed

    What is the root cause of that problem?

    // Only navigate to concierge chat when central pane is visible
    // Otherwise stay on the chats screen.
    if (isSmallScreenWidth) {
    Navigation.navigate(ROUTES.HOME);
    } else if (AccountUtils.isAccountIDOddNumber(accountID ?? 0)) {

    Currently, the App only navigate to concierge chat when central pane is visible

    What changes do you think we should make in order to solve the problem?

    Let's delete this part

    // Otherwise stay on the chats screen.
    if (isSmallScreenWidth) {

    The app will then redirect users to the concierge chat when onboarding flow completed

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. melvin-bot commented on Jun 17, 2024

    @melvin-bot

    @slafortune Huh... This is 4 days overdue. Who can take care of this?

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 17, 2024
  6. melvin-bot commented on Jun 17, 2024

    @melvin-bot
  7. changed the title [-]Chats - User remains on LHN page after onboarding flow completed[/-] [+][$250] Chats - User remains on LHN page after onboarding flow completed[/+] on Jun 17, 2024
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 17, 2024
  9. melvin-bot commented on Jun 17, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  10. hoangzinh commented on Jun 18, 2024

    @hoangzinh
    Contributor

    Confirming expected behavior here #41343 (comment)

  11. mountiny commented on Jun 20, 2024

    @mountiny
    Contributor

    It seems like you should be redirected to the chat #38774 (comment)

  12. mountiny commented on Jun 20, 2024

    @mountiny
    Contributor
  13. mountiny commented on Jun 20, 2024

    @mountiny
    Contributor

    This seems to be by design on narrow devices https://expensify.slack.com/archives/C036QM0SLJK/p1718898938705079?thread_ts=1718885687.316199&cid=C036QM0SLJK

    @slafortune would you be able to please update any testrail cases related to this to make sure they say that on mobile/ narrow screens the users are navigated to LHN after completing the flow? thank you!

  14. self-assigned this
    on Jun 20, 2024
  15. slafortune commented on Jun 21, 2024

    @slafortune
    Contributor

    Added to the regression test - close since this is expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions