You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Chats - User remains on LHN page after onboarding flow completed #43564
The app will then redirect users to the concierge chat when onboarding flow completed
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Chats - User remains on LHN page after onboarding flow completed[/-][+][$250] Chats - User remains on LHN page after onboarding flow completed[/+]on Jun 17, 2024
@slafortune would you be able to please update any testrail cases related to this to make sure they say that on mobile/ narrow screens the users are navigated to LHN after completing the flow? thank you!
Activity
melvin-bot commentedon Jun 12, 2024
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.cretadn22 commentedon Jun 12, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
User remains on LHN page after onboarding flow completed
What is the root cause of that problem?
App/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx
Lines 71 to 75 in b70b136
Currently, the App only navigate to concierge chat when central pane is visible
What changes do you think we should make in order to solve the problem?
Let's delete this part
App/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx
Lines 72 to 73 in b70b136
The app will then redirect users to the concierge chat when onboarding flow completed
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Jun 17, 2024
@slafortune Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Jun 17, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0170226485ccb489be
[-]Chats - User remains on LHN page after onboarding flow completed[/-][+][$250] Chats - User remains on LHN page after onboarding flow completed[/+]melvin-bot commentedon Jun 17, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (
External)hoangzinh commentedon Jun 18, 2024
Confirming expected behavior here #41343 (comment)
mountiny commentedon Jun 20, 2024
It seems like you should be redirected to the chat #38774 (comment)
mountiny commentedon Jun 20, 2024
asked https://expensify.slack.com/archives/C036QM0SLJK/p1718885687316199
mountiny commentedon Jun 20, 2024
This seems to be by design on narrow devices https://expensify.slack.com/archives/C036QM0SLJK/p1718898938705079?thread_ts=1718885687.316199&cid=C036QM0SLJK
@slafortune would you be able to please update any testrail cases related to this to make sure they say that on mobile/ narrow screens the users are navigated to LHN after completing the flow? thank you!
slafortune commentedon Jun 21, 2024
Added to the regression test - close since this is expected.