Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.82-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4621858
Email or phone of affected tester (no customers): applausetester+jp_e_category_1@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
- Go to https://staging.new.expensify.com
- Log in
- Open any chat
- Click on + and select Assign task
- Enter task title
- Enter long description less than 500 character. My description: Chat is scrolled up when go back from the thread twice via header link 1. Go to https://staging.new.expensify.com/
- Log in. 3. Open any chat with a long history and send a message 4. Create a thread and send a message in thread 5. Navigate to the chat via header link 6. Click on reply link to open thread again 7. Navigate to the chat via header link again Last message with a thread is visible Chat is scrolled up and last message with a thread is not visible Platform: Web/mWeb
- Assign task to any user and confirm task
Expected Result:
Unable to create a task with a long description
Actual Result:
Unexpected error create task appears: Unexpected error create task, please try again later.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6510235_1718166255763.Long_description.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~011ddeeb8acc28f12c
- Upwork Job ID: 1801650121422631424
- Last Price Increase: 2024-06-14
- Automatic offers:
- truph01 | Contributor | 102799645
Activity
melvin-bot commentedon Jun 12, 2024
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Task – Unable to create a task with a long description, error appears[/-][+][$250] Task – Unable to create a task with a long description, error appears[/+]melvin-bot commentedon Jun 14, 2024
Job added to Upwork: https://www.upwork.com/jobs/~011ddeeb8acc28f12c
melvin-bot commentedon Jun 14, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)truph01 commentedon Jun 14, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Unexpected error create task appears: Unexpected error create task, please try again later.
What is the root cause of that problem?
In
App/src/pages/tasks/NewTaskDetailsPage.tsx
Line 64 in bdb9789
values.taskDescription.lengthto validate the length. But the task description is a markdown-enabled input, so later it will be converted to HTML when sending to back-end.After converted to HTML, the length of the text will be higher (more than 500), so back-end throws.
What changes do you think we should make in order to solve the problem?
Validate the task description using same way as other markdown-enabled inputs:
App/src/hooks/useHandleExceedMaxCommentLength.ts
Line 12 in bdb9789
App/src/pages/workspace/WorkspaceNewRoomPage.tsx
Line 186 in bdb9789
By using
ReportUtils.getCommentLengthto get the correct after-parsing length of the text, also consistent with back-endIn https://github.com/Expensify/App/blob/main/src/pages/tasks/NewTaskDetailsPage.tsx#L64-L66:
Same fix can apply to the task description edit page/other markdown-enabled inputs.
What alternative solutions did you explore? (Optional)
studentofcoding commentedon Jun 17, 2024
The solutions are on point
14 remaining items
[-][$250] Task – Unable to create a task with a long description, error appears[/-][+][HOLD for payment 2024-07-10] [$250] Task – Unable to create a task with a long description, error appears[/+]melvin-bot commentedon Jul 3, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 3, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mananjadhav commentedon Jul 10, 2024
I think we should've added this when we had Markdown support. I couldn't pint the exact PR when we added to the field. But now that we've added I don't think we need a regression test for this one.
@bfitzexpensify This is ready for payout.
bfitzexpensify commentedon Jul 10, 2024
Payment summary:
@mananjadhav to be paid $250 for C+ via manual request
@truph01 to be paid $250 for contributor work - paid ✅
JmillsExpensify commentedon Jul 11, 2024
$250 approved for @mananjadhav