Skip to content

[$250] Tag - Dependent tag violation message isn't changing to "all tags required" #43574

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when validating #40741
Version Number: 1.4.82-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition: Import the attached dependent_tags.csv in OD for a workspace. Enable multi level tags.

  1. Navigate to https://staging.new.expensify.com/

  2. Log in with an expensifail account

  3. Navigate to the workspace chat

  4. Start submitting a manual expense

  5. Only input the "Merchant" field on the confirmation page

  6. Submit the expense

  7. Open the expense

  8. Click on any of the three missing tags

  9. Choose any of the options

Expected Result:

The message should change to "all tags required" for the reported missing tags.

Actual Result:

Dependent tag violation message isn't changing to "all tags required" for the rest of the tags when there are multiple missing tags and one is selected.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6510487_1718181753132!dependent_tags.csv

Bug6510487_1718181753145.bandicam_2024-06-12_10-20-07-860.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013b410860cea8f950
  • Upwork Job ID: 1801658425666734007
  • Last Price Increase: 2024-08-02
Issue OwnerCurrent Issue Owner: @yuwenmemon

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 12, 2024
  2. melvin-bot commented on Jun 12, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. kavimuru commented on Jun 12, 2024

    @kavimuru
    Author

    @twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  4. kavimuru commented on Jun 12, 2024

    @kavimuru
    Author

    We think this bug might be related to #wave-collect - Release 1

  5. twisterdotcom commented on Jun 13, 2024

    @twisterdotcom
    Contributor

    Also got this: #38682.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 14, 2024
  7. changed the title [-]Tag - Dependent tag violation message isn't changing to "all tags required"[/-] [+][$250] Tag - Dependent tag violation message isn't changing to "all tags required"[/+] on Jun 14, 2024
  8. melvin-bot commented on Jun 14, 2024

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 14, 2024
  10. melvin-bot commented on Jun 14, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

  11. melvin-bot commented on Jun 17, 2024

    @melvin-bot

    @twisterdotcom, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  12. 58 remaining items

  13. self-assigned this
    on Aug 17, 2024
  14. yuwenmemon commented on Aug 28, 2024

    @yuwenmemon
    Contributor

    Will look at this as a part of the tags project soon.

  15. teneeto commented on Aug 29, 2024

    @teneeto
    Contributor

    Cool, @yuwenmemon, I'm still here; please let me know if I can come in for any help.

  16. twisterdotcom commented on Sep 9, 2024

    @twisterdotcom
    Contributor

    This is going through the motions internally now.

  17. yuwenmemon commented on Sep 18, 2024

    @yuwenmemon
    Contributor

    I don't get it.... this happens for independent tags too. Are we sure we need this to say "all tags required"? cc @cead22

    Kapture.2024-09-17.at.23.16.26.mp4
  18. twisterdotcom commented on Sep 19, 2024

    @twisterdotcom
    Contributor

    Hmm good point, I think given we say "Missing tagName" for each level, this is fine now.

  19. yuwenmemon commented on Sep 19, 2024

    @yuwenmemon
    Contributor

    Sweet - closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions