Skip to content

[HOLD for payment 2024-06-20] Track - "Hold" appears for tracked expense on right-click menu, but not in transaction thread #43589

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.82-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Submit an expense
  4. Track an expense
  5. Go to transaction thread of tracked expense
  6. Click 3-dot menu
  7. Note that Hold option is absent
  8. Return to expense report
  9. Right click on the tracked expense

Expected Result:

Hold option will not appear for tracked expense

Actual Result:

Hold option appears for tracked expense on right-click menu, but not in transaction thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6511003_1718206687222.20240612_233442.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @OfstadC

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 12, 2024
  2. melvin-bot commented on Jun 12, 2024

    @melvin-bot

    Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jun 12, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jun 12, 2024

    @lanitochka17
    Author

    @deetergp FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. lanitochka17 commented on Jun 12, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-collect - Release 1

  6. luacmartins commented on Jun 13, 2024

    @luacmartins
    Contributor

    This should be fixed with the next Auth deploy, besides this is already in prod so NAB.

  7. 2 remaining items

  8. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to @OfstadC (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  9. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  10. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

  11. self-assigned this
    on Jun 13, 2024
  12. luacmartins commented on Jun 13, 2024

    @luacmartins
    Contributor

    Confirmed that this has been solved in staging after the last Auth deploy. Closing.

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 13, 2024
  14. changed the title [-]Track - "Hold" appears for tracked expense on right-click menu, but not in transaction thread[/-] [+][HOLD for payment 2024-06-20] Track - "Hold" appears for tracked expense on right-click menu, but not in transaction thread[/+] on Jun 13, 2024
  15. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-20. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions