You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-10] [$250] LHN-Unpinned and read "Expensify" chat persists in LHN in "#focus" priority mode #43599
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
OK, I verified I can reproduce it on staging. Since this doesn't prevent the user from doing anything, I'm going to demote this as a blocker and make it an external issue instead.
@tgolen about this #44061 (comment), I'll need probably some time till end of this week to add unit tests for this functionality. I guess if this issue is still kept open at that time then that's should be fine, no worries!
changed the title [-][$250] LHN-Unpinned and read "Expensify" chat persists in LHN in "#focus" priority mode[/-][+][HOLD for payment 2024-07-10] [$250] LHN-Unpinned and read "Expensify" chat persists in LHN in "#focus" priority mode[/+]on Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
[@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@alitoshmatov] Determine if we should create a regression test for this bug.
[@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
Determine if we should create a regression test for this bug. No need as there are regression tests to catch a similar issues. Like when chat does not have unread messages and is not pinned should not show up in focus mode
Activity
melvin-bot commentedon Jun 12, 2024
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 12, 2024
Triggered auto assignment to @tgolen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 12, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
tgolen commentedon Jun 12, 2024
OK, I verified I can reproduce it on staging. Since this doesn't prevent the user from doing anything, I'm going to demote this as a blocker and make it an external issue instead.
30 remaining items
dominictb commentedon Jun 24, 2024
@tgolen about this #44061 (comment), I'll need probably some time till end of this week to add unit tests for this functionality. I guess if this issue is still kept open at that time then that's should be fine, no worries!
[-][$250] LHN-Unpinned and read "Expensify" chat persists in LHN in "#focus" priority mode[/-][+][HOLD for payment 2024-07-10] [$250] LHN-Unpinned and read "Expensify" chat persists in LHN in "#focus" priority mode[/+]melvin-bot commentedon Jul 3, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 3, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
slafortune commentedon Jul 8, 2024
@alitoshmatov can you please complete the checklist?
alitoshmatov commentedon Jul 9, 2024
cc: @slafortune
slafortune commentedon Jul 10, 2024
@allgandalf Paid $250 via Upworks ✅
@dominictb Paid $250 via Upworks ✅