Skip to content

[HOLD for payment 2024-07-10] [$250] LHN-Unpinned and read "Expensify" chat persists in LHN in "#focus" priority mode #43599

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.82-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4623718
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Log in to New Expensify with new account
  2. Proceed through the onboarding flow
  3. Open the "Expensify" chat
  4. Navigate to the Account Settings > Preferences
  5. Set Priority mode to "#focus"
  6. Return to the LHN

Expected Result:

The "Expensify" chat should disappear from LHN for user in #focus mode as it is read, unpinned, there is no drafted message or GBR

Actual Result:

The "Expensify" chat remains in LHN.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6511119_1718212788958.Record_2024-06-12-19-03-54.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01efa7c4d8efd2418e
  • Upwork Job ID: 1800979546429480418
  • Last Price Increase: 2024-06-12
  • Automatic offers:
    • alitoshmatov | Reviewer | 102766394
    • dominictb | Contributor | 102766397
Issue OwnerCurrent Issue Owner: @slafortune

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 12, 2024
  2. melvin-bot commented on Jun 12, 2024

    @melvin-bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 12, 2024

    @melvin-bot

    Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Jun 12, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. tgolen commented on Jun 12, 2024

    @tgolen
    Contributor

    OK, I verified I can reproduce it on staging. Since this doesn't prevent the user from doing anything, I'm going to demote this as a blocker and make it an external issue instead.

  6. 30 remaining items

  7. dominictb commented on Jun 24, 2024

    @dominictb
    Contributor

    @tgolen about this #44061 (comment), I'll need probably some time till end of this week to add unit tests for this functionality. I guess if this issue is still kept open at that time then that's should be fine, no worries!

  8. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 3, 2024
  9. changed the title [-][$250] LHN-Unpinned and read "Expensify" chat persists in LHN in "#focus" priority mode[/-] [+][HOLD for payment 2024-07-10] [$250] LHN-Unpinned and read "Expensify" chat persists in LHN in "#focus" priority mode[/+] on Jul 3, 2024
  10. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-10. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
    • [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@alitoshmatov] Determine if we should create a regression test for this bug.
    • [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. slafortune commented on Jul 8, 2024

    @slafortune
    Contributor

    @alitoshmatov can you please complete the checklist?

  14. alitoshmatov commented on Jul 9, 2024

    @alitoshmatov
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: Feature/38774 expensify persona #41343
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/41343/files#r1671215928
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
    • Determine if we should create a regression test for this bug. No need as there are regression tests to catch a similar issues. Like when chat does not have unread messages and is not pinned should not show up in focus mode

    cc: @slafortune

  15. slafortune commented on Jul 10, 2024

    @slafortune
    Contributor

    @allgandalf Paid $250 via Upworks ✅
    @dominictb Paid $250 via Upworks ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions