Skip to content

[HOLD for payment 2024-06-24] [$250] The FAB or Search category selector are narrow  #43657

Closed

Description

@mountiny

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1718283502781369

Action Performed:

Break down in numbered steps

  1. Click on the + green button
  2. Or go to Search page and select Expenses to choose different category to show

Expected Result:

Describe what you think should've happened

The modal show take the entire width of the screen

Actual Result:

Describe what actually happened

The modal is very narrow

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

RPReplay_Final1718283365.MP4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0163f71b7719038ed3
  • Upwork Job ID: 1801238352430390753
  • Last Price Increase: 2024-06-13
  • Automatic offers:
    • hoangzinh | Reviewer | 102723522
    • bernhardoj | Contributor | 102723525
Issue OwnerCurrent Issue Owner: @johncschuster

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 13, 2024
  2. changed the title [-]The FAB or Search category selector are narrow [/-] [+][$250] The FAB or Search category selector are narrow [/+] on Jun 13, 2024
  3. melvin-bot commented on Jun 13, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 13, 2024
  5. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  6. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  7. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  8. 39 remaining items

  9. johncschuster commented on Jun 25, 2024

    @johncschuster
    Contributor

    Payment Summary:

    Contributor+: @allroundexperts - $250 - paid via Manual request
    Contributor: @bernhardoj - $250 - paid via Upwork - PAID

    @allroundexperts, can you complete the BZ Checklist when you get a moment? Thank you!

  10. luacmartins commented on Jun 27, 2024

    @luacmartins
    Contributor

    I think the due date here is the 24th. Updated the title to reflect that.

  11. changed the title [-][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] The FAB or Search category selector are narrow [/-] [+][HOLD for payment 2024-06-24] [$250] The FAB or Search category selector are narrow [/+] on Jun 27, 2024
  12. johncschuster commented on Jun 27, 2024

    @johncschuster
    Contributor

    Yep! Payment has already been issued via Upwork. We're just waiting on the BZ Checklist to be completed.

  13. johncschuster commented on Jun 28, 2024

    @johncschuster
    Contributor

    @allroundexperts can you complete the BZ Checklist above? Once finished, we can close this up.

  14. allroundexperts commented on Jun 30, 2024

    @allroundexperts
    Contributor

    Checklist

    1. Add focus trap #39520
    2. The software mansion team was aware of this issue already here.
    3. N/A
    4. I think that the FAB and search category selector are being covered in other regression tests so a new one is not needed.
  15. johncschuster commented on Jul 1, 2024

    @johncschuster
    Contributor

    Thanks, @allroundexperts! Please go ahead and request payment if you haven't already!

  16. JmillsExpensify commented on Jul 20, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions