Skip to content

[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] Chat - First menu item in the composer is highlighted #43659

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to chat.
  3. Tap +.

Expected Result:

The menu item will not be highlighted by default.

Actual Result:

The first menu item is highlighted.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6511959_1718284380063.composer.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @muttmuure

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 13, 2024
  2. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Jun 13, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Jun 13, 2024

    @izarutskaya
    Author

    @muttmuure I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Jun 13, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #vip-vsb.

  7. luacmartins commented on Jun 13, 2024

    @luacmartins
    Contributor

    Seems like a regression from focus trap #39520

  8. 24 remaining items

  9. melvin-bot commented on Jun 17, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-24. 🎊

    For reference, here are some details about the assignees on this issue:

    • @jnowakow does not require payment (Contractor)
  10. melvin-bot commented on Jun 17, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@amyevans] The PR that introduced the bug has been identified. Link to the PR:
    • [@amyevans] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@amyevans] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@jnowakow] Determine if we should create a regression test for this bug.
    • [@jnowakow] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. parasharrajat commented on Jun 20, 2024

    @parasharrajat
    Member

    C+ payment is pending for the PR review #43743. @amyevans Could you please assign me and post the summary?

  12. luacmartins commented on Jun 20, 2024

    @luacmartins
    Contributor

    @muttmuure all yours to handle payment

  13. changed the title [-][HOLD for payment 2024-06-24] Chat - First menu item in the composer is highlighted[/-] [+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] Chat - First menu item in the composer is highlighted[/+] on Jun 21, 2024
  14. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-28. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
    • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@parasharrajat] Determine if we should create a regression test for this bug.
    • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. parasharrajat commented on Jun 29, 2024

    @parasharrajat
    Member

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Regression Test Steps

    1. Open modal (click green plus button in LHP)
    2. Verify that first element is not highlighted initially

    1. Go to staging.new.expensify.com
    2. Go to workspace settings > Categories
    3. Select all the categories via checkbox
    4. Click Select
    5. Unselect all the categories
    6. Select all the categories
    7. Click Select
    8. The Categories header will not jump when clicking Select

    Do you agree 👍 or 👎 ?

  17. parasharrajat commented on Jun 29, 2024

    @parasharrajat
    Member

    @muttmuure Could you please post the payment summary? Thank you.

  18. parasharrajat commented on Jul 12, 2024

    @parasharrajat
    Member

    Payment requested

  19. mallenexpensify commented on Jul 16, 2024

    @mallenexpensify
    Contributor
  20. JmillsExpensify commented on Jul 16, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions