Skip to content

[HOLD for payment 2024-08-02] [HOLD for payment 2024-07-25] [$500] Web - Expense - Blue border selection on back icon RHP after hitting enter on BNP #43662

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to chat
  3. Go to + > Submit expense > Manual
  4. Enter amount
  5. Hit Enter

Expected Result:

The back icon on RHP will not have blue border selection

Actual Result:

The back icon on RHP has blue border selection

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6511961_1718284382905.enter.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018358d1ec7f51e120
  • Upwork Job ID: 1801251133562170195
  • Last Price Increase: 2024-06-27
  • Automatic offers:
    • suneox | Contributor | 102988636
Issue OwnerCurrent Issue Owner: @s77rt

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 13, 2024
  2. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jun 13, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jun 13, 2024

    @lanitochka17
    Author

    @danieldoglas FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. lanitochka17 commented on Jun 13, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  6. danieldoglas commented on Jun 13, 2024

    @danieldoglas
    Contributor

    Not a deploy blocker related to web, removing the label

  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jun 13, 2024
  8. 80 remaining items

  9. s77rt commented on Jul 26, 2024

    @s77rt
    Member

    @joekaufmanexpensify This should be $250 for causing a regression #45571

  10. JmillsExpensify commented on Jul 26, 2024

    @JmillsExpensify
    Contributor

    @joekaufmanexpensify mind updating the payment summary above?

  11. changed the title [-][HOLD for payment 2024-07-25] [$500] Web - Expense - Blue border selection on back icon RHP after hitting enter on BNP[/-] [+][HOLD for payment 2024-08-02] [HOLD for payment 2024-07-25] [$500] Web - Expense - Blue border selection on back icon RHP after hitting enter on BNP[/+] on Jul 26, 2024
  12. melvin-bot commented on Jul 26, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-02. 🎊

    For reference, here are some details about the assignees on this issue:

  13. joekaufmanexpensify commented on Jul 26, 2024

    @joekaufmanexpensify
    Contributor

    Ah okay got it. I don't see that there was a post to the issue about the deploy blocker/regression previously, which is why it was not previously noted in the payment summary.

    Updated payment summary to note that both parties are actually due $250 here because of the regression.

  14. joekaufmanexpensify commented on Jul 26, 2024

    @joekaufmanexpensify
    Contributor

    I need to request a $250 refund from @suneox via Upwork. Getting an insufficient permissions error in upwork requesting a refund. Updating my permissions via this SO to allow processing refunds.

  15. suneox commented on Jul 26, 2024

    @suneox
    Contributor

    I need to request a $250 refund from @suneox via Upwork. Getting an insufficient permissions error in upwork requesting a refund. Updating my permissions via this SO to allow processing refunds.

    Sure, I'm looking for the refund section on Upwork and process ASAP

  16. joekaufmanexpensify commented on Jul 26, 2024

    @joekaufmanexpensify
    Contributor

    All good!I haven't requested it yet. Will let you know once I do!

  17. suneox commented on Jul 26, 2024

    @suneox
    Contributor

    @joekaufmanexpensify I have refunded 50%

  18. joekaufmanexpensify commented on Jul 26, 2024

    @joekaufmanexpensify
    Contributor

    Ah, perfect. TY! I see it processed on my end.

  19. joekaufmanexpensify commented on Jul 26, 2024

    @joekaufmanexpensify
    Contributor

    Okay, now all that's left is to process $250 payment to @s77rt. Payment summary here.

  20. JmillsExpensify commented on Jul 26, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @s77rt

  21. eh2077 commented on Sep 29, 2025

    @eh2077
    Contributor

    There seems no upstream issue for the focus-trap patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions