Skip to content

[HOLD for payment 2024-07-10] [HOLD for payment 2024-06-28] [LOW] [Performance] Refactor ReportActionItem.tsx and MoneyRequestConfirmationList.tsx #43663

Closed

Description

@mountiny

Problem

There is a huge component (>1.1k lines) - ReportActionItem.

Solution

There is an option to pick a scope of the “created” action rendering and move it to a new file. The new file can be called ReportActionItemContentCreated. It is a stateless component and gets props from the parent. Obviously, we can apply React.memo for this child component. This change saves 117 lines of ReportActionItem.

Before: 1118 lines / After: 1001 lines / Diff: 117 lines.
I did some measures and recorded mean value. So It really improves the rendering of the created action.

Before: 2.4ms / After 2.1ms around 15% of improvement.
This change doesn’t have a predictable improvement for text actions, the numbers floats for the legacy and updated versions. However, if the user refresh the page, there is a slight boost.

Before: 3.8ms / After 3.5ms around 9% of improvement.
A commit is here.

cc @rezkiy37

Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 13, 2024
  2. self-assigned this
    on Jun 13, 2024
  3. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 13, 2024
  4. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

  5. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. moved this from MEDIUM to LOW in [#whatsnext] #qualityon Jun 13, 2024
  7. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

  8. rezkiy37 commented on Jun 13, 2024

    @rezkiy37
    Contributor

    Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

  9. 24 remaining items

  10. melvin-bot commented on Jul 1, 2024

    @melvin-bot

    @abekkala, @s77rt, @mountiny, @rezkiy37 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  11. s77rt commented on Jul 1, 2024

    @s77rt
    Member

    Not overdue. Waiting for #43749 to hit production

  12. abekkala commented on Jul 3, 2024

    @abekkala
    Contributor

    still waiting on #43749 to merge to production

  13. changed the title [-][HOLD for payment 2024-06-28] [LOW] [Performance] Refactor ReportActionItem.tsx and MoneyRequestConfirmationList.tsx[/-] [+][HOLD for payment 2024-07-10] [HOLD for payment 2024-06-28] [LOW] [Performance] Refactor ReportActionItem.tsx and MoneyRequestConfirmationList.tsx[/+] on Jul 3, 2024
  14. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-10. 🎊

    For reference, here are some details about the assignees on this issue:

    • @s77rt requires payment through NewDot Manual Requests
    • @rezkiy37 does not require payment (Contractor)
  15. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
    • [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@s77rt] Determine if we should create a regression test for this bug.
    • [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. mountiny commented on Jul 5, 2024

    @mountiny
    ContributorAuthor

    $250 to @s77rt once the time comes, no regression testing required

  17. abekkala commented on Jul 8, 2024

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR JULY 10

    • Fix: @rezkiy37 - callstack no upwork payment needed
    • PR Review: @s77rt [$250] payment via NewDot
  18. JmillsExpensify commented on Jul 10, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @s77rt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

AutoAssignerNewDotQualityUsed to assign quality issues to engineersAwaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions