You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-10] [HOLD for payment 2024-06-28] [LOW] [Performance] Refactor ReportActionItem.tsx and MoneyRequestConfirmationList.tsx #43663
There is an option to pick a scope of the “created” action rendering and move it to a new file. The new file can be called ReportActionItemContentCreated. It is a stateless component and gets props from the parent. Obviously, we can apply React.memo for this child component. This change saves 117 lines of ReportActionItem.
Before: 1118 lines / After: 1001 lines / Diff: 117 lines.
I did some measures and recorded mean value. So It really improves the rendering of the created action.
Before: 2.4ms / After 2.1ms around 15% of improvement.
This change doesn’t have a predictable improvement for text actions, the numbers floats for the legacy and updated versions. However, if the user refresh the page, there is a slight boost.
Before: 3.8ms / After 3.5ms around 9% of improvement.
A commit is here.
changed the title [-][HOLD for payment 2024-06-28] [LOW] [Performance] Refactor ReportActionItem.tsx and MoneyRequestConfirmationList.tsx[/-][+][HOLD for payment 2024-07-10] [HOLD for payment 2024-06-28] [LOW] [Performance] Refactor ReportActionItem.tsx and MoneyRequestConfirmationList.tsx[/+]on Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jun 13, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)melvin-bot commentedon Jun 13, 2024
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 13, 2024
Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.
rezkiy37 commentedon Jun 13, 2024
Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.
24 remaining items
melvin-bot commentedon Jul 1, 2024
@abekkala, @s77rt, @mountiny, @rezkiy37 Whoops! This issue is 2 days overdue. Let's get this updated quick!
s77rt commentedon Jul 1, 2024
Not overdue. Waiting for #43749 to hit production
abekkala commentedon Jul 3, 2024
still waiting on #43749 to merge to production
[-][HOLD for payment 2024-06-28] [LOW] [Performance] Refactor ReportActionItem.tsx and MoneyRequestConfirmationList.tsx[/-][+][HOLD for payment 2024-07-10] [HOLD for payment 2024-06-28] [LOW] [Performance] Refactor ReportActionItem.tsx and MoneyRequestConfirmationList.tsx[/+]melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 3, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mountiny commentedon Jul 5, 2024
$250 to @s77rt once the time comes, no regression testing required
abekkala commentedon Jul 8, 2024
PAYMENT SUMMARY FOR JULY 10
JmillsExpensify commentedon Jul 10, 2024
$250 approved for @s77rt