You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] mweb - Login - Sign in page scroll to bottom when sign in from public room #43664
Version Number: 1.4.83-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Logout of ND if logged in
Visit any public room
Press Sign In button on the bottom right
Expected Result:
Sign in page and email section should be present
Actual Result:
Sign in page scroll to bottom when sign in from public room
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-] mweb - Login - Sign in page scroll to bottom when sign in from public room[/-][+][$250] mweb - Login - Sign in page scroll to bottom when sign in from public room[/+]on Jun 13, 2024
The PR that introduced the bug has been identified. Link to the PR: Add focus trap #39520
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add focus trap #39520 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes - if there isn't already one
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Logout of ND if logged in
Visit any public room
Press Sign In button on the bottom right
Verify that the sign in page shows scrolled to the top, with the email field visible
Activity
melvin-bot commentedon Jun 13, 2024
Triggered auto assignment to @stitesExpensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 13, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jun 13, 2024
@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jun 13, 2024
We think that this bug might be related to #vip-vsp
luacmartins commentedon Jun 13, 2024
Likely caused by #39520
[-] mweb - Login - Sign in page scroll to bottom when sign in from public room[/-][+][$250] mweb - Login - Sign in page scroll to bottom when sign in from public room[/+]melvin-bot commentedon Jun 13, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01fe15cd5ddd85477d
27 remaining items
jjcoffee commentedon Jun 26, 2024
Regression Test Proposal
Do we agree 👍 or 👎
mountiny commentedon Jun 26, 2024
I think we do not have to add a specific regression test for this. It would be quickly noticeable when this regressed
isabelastisser commentedon Jun 26, 2024
Not overdue, payment is on Friday the 28th.
jnowakow commentedon Jun 28, 2024
I'm from Software Mansion, an expert agency, so I'm not sure if there should be any payment 😅
isabelastisser commentedon Jun 28, 2024
@jnowakow, thanks for the heads up! That's correct; payment is to @jjcoffee only.
isabelastisser commentedon Jun 28, 2024
@jjcoffee, I sent you the offer in Upwork.
All set!
jjcoffee commentedon Jul 1, 2024
@isabelastisser Accepted, thanks!
jjcoffee commentedon Jul 4, 2024
@isabelastisser Friendly bump to complete the payment 🙏
isabelastisser commentedon Jul 8, 2024
Sorry for the delay, @jjcoffee! I will complete the payment in Upwork now. Thanks!
isabelastisser commentedon Jul 8, 2024
All set.