Skip to content

[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] mweb - Login - Sign in page scroll to bottom when sign in from public room #43664

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Logout of ND if logged in
  2. Visit any public room
  3. Press Sign In button on the bottom right

Expected Result:

Sign in page and email section should be present

Actual Result:

Sign in page scroll to bottom when sign in from public room

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1945.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fe15cd5ddd85477d
  • Upwork Job ID: 1801337191813004274
  • Last Price Increase: 2024-06-13
Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 13, 2024
  2. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jun 13, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jun 13, 2024

    @lanitochka17
    Author

    @stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. lanitochka17 commented on Jun 13, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  6. luacmartins commented on Jun 13, 2024

    @luacmartins
    Contributor

    Likely caused by #39520

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerIndicates it should block deploying the API
    on Jun 13, 2024
  8. changed the title [-] mweb - Login - Sign in page scroll to bottom when sign in from public room[/-] [+][$250] mweb - Login - Sign in page scroll to bottom when sign in from public room[/+] on Jun 13, 2024
  9. melvin-bot commented on Jun 13, 2024

    @melvin-bot
  10. 27 remaining items

  11. jjcoffee commented on Jun 26, 2024

    @jjcoffee
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: Add focus trap #39520
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add focus trap #39520 (comment)
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug. Yes - if there isn't already one
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Logout of ND if logged in
    2. Visit any public room
    3. Press Sign In button on the bottom right
    4. Verify that the sign in page shows scrolled to the top, with the email field visible

    Do we agree 👍 or 👎

  12. mountiny commented on Jun 26, 2024

    @mountiny
    Contributor

    I think we do not have to add a specific regression test for this. It would be quickly noticeable when this regressed

  13. isabelastisser commented on Jun 26, 2024

    @isabelastisser
    Contributor

    Not overdue, payment is on Friday the 28th.

  14. jnowakow commented on Jun 28, 2024

    @jnowakow
    Contributor

    I'm from Software Mansion, an expert agency, so I'm not sure if there should be any payment 😅

  15. isabelastisser commented on Jun 28, 2024

    @isabelastisser
    Contributor

    @jnowakow, thanks for the heads up! That's correct; payment is to @jjcoffee only.

  16. isabelastisser commented on Jun 28, 2024

    @isabelastisser
    Contributor

    @jjcoffee, I sent you the offer in Upwork.

    All set!

  17. jjcoffee commented on Jul 1, 2024

    @jjcoffee
    Contributor

    @isabelastisser Accepted, thanks!

  18. jjcoffee commented on Jul 4, 2024

    @jjcoffee
    Contributor

    @isabelastisser Friendly bump to complete the payment 🙏

  19. isabelastisser commented on Jul 8, 2024

    @isabelastisser
    Contributor

    Sorry for the delay, @jjcoffee! I will complete the payment in Upwork now. Thanks!

  20. isabelastisser commented on Jul 8, 2024

    @isabelastisser
    Contributor

    All set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions