Skip to content

[$250] Pay someone - Console error shows up when changing payment #43691

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.83-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Pay someone.
  3. Enter amount in any currency except USD, select a user and pay them.
  4. Go to FAB > Pay someone.
  5. Enter amount in USD and select the same user.
  6. On confirmation page, click on the dropdown.
  7. Choose Pay elsewhere.

Expected Result:

No console error will show up.

Actual Result:

Console error shows up.
[Onyx] Warning: Trying to apply "merge" with non-array type to array type in the key "nvp_private_lastPaymentMethod"

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

20240614_001248.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d201b1908116ec8e
  • Upwork Job ID: 1801295301666346552
  • Last Price Increase: 2024-06-13

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 13, 2024
  2. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jun 13, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. kbecciv commented on Jun 13, 2024

    @kbecciv
    Author

    Issue have been raised in adhoc build #42772 (comment)

  5. kbecciv commented on Jun 13, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave-collect - Release 1

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerIndicates it should block deploying the API
    on Jun 13, 2024
  7. melvin-bot commented on Jun 13, 2024

    @melvin-bot
  8. changed the title [-]Pay someone - Console error shows up when changing payment[/-] [+][$250] Pay someone - Console error shows up when changing payment[/+] on Jun 13, 2024
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 13, 2024
  10. 8 remaining items

  11. added and removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 13, 2024
  12. mountiny commented on Jun 14, 2024

    @mountiny
    Contributor

    Also QA confirmed this is not causing crashes in native https://expensify.slack.com/archives/C9YU7BX5M/p1718297508327499

  13. rlinoz commented on Jun 17, 2024

    @rlinoz
    Contributor

    Moving this to weekly for now, it should be fine since it is not crashing or disrupting functionality.

  14. added and removed on Jun 17, 2024
  15. rlinoz commented on Jun 26, 2024

    @rlinoz
    Contributor

    I have an idea on how to fix this, there is a PR in progress.

  16. rlinoz commented on Jul 12, 2024

    @rlinoz
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions