You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] mWeb - Chat - Emoji picker cut off in the bottom #43692
Version Number: 1.4.83-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Log in to New Expensify
Navigate to any chat
Open emoji picker
Expected Result:
Emoji picker should be fully rendered to the very bottom of the screen
Actual Result:
Emoji picker is cut off in the bottom
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@deetergp FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
📣 @daledah! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Activity
melvin-bot commentedon Jun 13, 2024
Triggered auto assignment to @deetergp (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 13, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jun 13, 2024
@deetergp FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jun 13, 2024
We think that this bug might be related to #vip-vsp
[-]mWeb - Chat - Emoji picker cut off in the bottom[/-][+][$250] mWeb - Chat - Emoji picker cut off in the bottom[/+]melvin-bot commentedon Jun 13, 2024
Job added to Upwork: https://www.upwork.com/jobs/~015d3ee2fb419bfdb5
melvin-bot commentedon Jun 13, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (
External)mountiny commentedon Jun 13, 2024
This does not feel like a blocker to me, feel free to change that but demoting
daledah commentedon Jun 13, 2024
Please re-state the problem that we are trying to solve in this issue.
Emoji picker is cut off in the bottom
What is the root cause of that problem?
In here , We added an extra View without any style when we added FocusTrap before.
What changes do you think we should make in order to solve the problem?
We can fix this bug by Remove the extra View
App/src/components/Modal/BaseModal.tsx
Line 256 in 361a000
What alternative solutions did you explore? (Optional)
melvin-bot commentedon Jun 13, 2024
📣 @daledah! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
rayane-d commentedon Jun 14, 2024
@daledah - It looks like the extra
Viewis necessary, see https://github.com/Expensify/App/pull/39520/files#r1634713582rayane-d commentedon Jun 14, 2024
Offending PR: #39520
rayane-d commentedon Jun 16, 2024
Looking for better proposals
rayane-d commentedon Jun 16, 2024
@deetergp - Can you please add
Buglabel? Thanksdaledah commentedon Jun 17, 2024
@rayane-djouah I think this issue has been fixed in this PR
rayane-d commentedon Jun 17, 2024
Yes, it is fixed. We can close this one @deetergp
rayane-d commentedon Jun 17, 2024
Thank you for your help @daledah