Skip to content

[$250] mWeb - Chat - Emoji picker cut off in the bottom #43692

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Log in to New Expensify
  2. Navigate to any chat
  3. Open emoji picker

Expected Result:

Emoji picker should be fully rendered to the very bottom of the screen

Actual Result:

Emoji picker is cut off in the bottom

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6512117_1718293278184.Record_2024-06-13-17-17-32.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015d3ee2fb419bfdb5
  • Upwork Job ID: 1801295914996738899
  • Last Price Increase: 2024-06-13
Issue OwnerCurrent Issue Owner: @rayane-djouah

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 13, 2024
  2. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jun 13, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jun 13, 2024

    @lanitochka17
    Author

    @deetergp FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. lanitochka17 commented on Jun 13, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerIndicates it should block deploying the API
    on Jun 13, 2024
  7. changed the title [-]mWeb - Chat - Emoji picker cut off in the bottom[/-] [+][$250] mWeb - Chat - Emoji picker cut off in the bottom[/+] on Jun 13, 2024
  8. melvin-bot commented on Jun 13, 2024

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 13, 2024
  10. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

  11. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jun 13, 2024
  12. mountiny commented on Jun 13, 2024

    @mountiny
    Contributor

    This does not feel like a blocker to me, feel free to change that but demoting

  13. daledah commented on Jun 13, 2024

    @daledah
    Contributor

    Please re-state the problem that we are trying to solve in this issue.

    Emoji picker is cut off in the bottom

    What is the root cause of that problem?

    In here , We added an extra View without any style when we added FocusTrap before.

    What changes do you think we should make in order to solve the problem?

    We can fix this bug by Remove the extra View

    What alternative solutions did you explore? (Optional)

  14. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    📣 @daledah! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  15. rayane-d commented on Jun 14, 2024

    @rayane-d
    Contributor
  16. rayane-d commented on Jun 14, 2024

    @rayane-d
    Contributor

    Offending PR: #39520

  17. rayane-d commented on Jun 16, 2024

    @rayane-d
    Contributor

    Looking for better proposals

  18. rayane-d commented on Jun 16, 2024

    @rayane-d
    Contributor

    @deetergp - Can you please add Bug label? Thanks

  19. daledah commented on Jun 17, 2024

    @daledah
    Contributor

    @rayane-djouah I think this issue has been fixed in this PR

  20. rayane-d commented on Jun 17, 2024

    @rayane-d
    Contributor

    Yes, it is fixed. We can close this one @deetergp

    Screenshot_20240617-192811.png

  21. rayane-d commented on Jun 17, 2024

    @rayane-d
    Contributor

    Thank you for your help @daledah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions