You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] QBO-incorrect toggle row style for Default vendor #43730
changed the title [-]QBO-incorrect toggle row style for Default vendor[/-][+][$250] QBO-incorrect toggle row style for Default vendor[/+]on Jun 17, 2024
changed the title [-][$250] QBO-incorrect toggle row style for Default vendor[/-][+][HOLD for payment 2024-07-02] [$250] QBO-incorrect toggle row style for Default vendor[/+]on Jun 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
[@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ikevin127] Determine if we should create a regression test for this bug.
[@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@ikevin127] Determine if we should create a regression test for this bug.
[@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Workspace is connected to QBO accounting.
Click Settings > Workspace.
Click on the workspace connected to QBO.
Click Accounting > Export.
Click Export company cards as.
Verify that the hint text for Default vendor is below the switch toggle.
changed the title [-][HOLD for payment 2024-07-02] [$250] QBO-incorrect toggle row style for Default vendor[/-][+][HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] QBO-incorrect toggle row style for Default vendor[/+]on Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
[@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ikevin127] Determine if we should create a regression test for this bug.
[@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jun 13, 2024
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.shawnborton commentedon Jun 13, 2024
cc @hayata-suenaga @trjExpensify
truph01 commentedon Jun 13, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Incorrect toggle row style for Default vendor
What is the root cause of that problem?
App/src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx
Line 67 in 9ddc788
we are using
ToggleSettingOptionRowwithoutshouldPlaceSubtitleBelowSwitch: trueWhat changes do you think we should make in order to solve the problem?
ToggleSettingOptionRowwithshouldPlaceSubtitleBelowSwitch: trueWhat alternative solutions did you explore? (Optional)
Result
[-]QBO-incorrect toggle row style for Default vendor[/-][+][$250] QBO-incorrect toggle row style for Default vendor[/+]melvin-bot commentedon Jun 17, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01a3aa3987291c1ed6
melvin-bot commentedon Jun 17, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (
External)15 remaining items
[-][$250] QBO-incorrect toggle row style for Default vendor[/-][+][HOLD for payment 2024-07-02] [$250] QBO-incorrect toggle row style for Default vendor[/+]melvin-bot commentedon Jun 25, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 25, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
abekkala commentedon Jun 26, 2024
PAYMENT SUMMARY FOR JULY 02
Please complete checklist
ikevin127 commentedon Jun 27, 2024
Regression Test Proposal
Precondition:
Export company cards as.Default vendoris below the switch toggle.Do we agree 👍 or 👎.
abekkala commentedon Jul 2, 2024
@truph01 and @ikevin127 payments sent and contracts ended - thank you! 🎉
[-][HOLD for payment 2024-07-02] [$250] QBO-incorrect toggle row style for Default vendor[/-][+][HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] QBO-incorrect toggle row style for Default vendor[/+]melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 3, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: