Skip to content

[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] QBO-incorrect toggle row style for Default vendor #43730

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.83-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1717488551565489

Action Performed:

Prerequisite: Workspace connected with QBO

  1. Go to staging.new.expensify.com
  2. Click Settings > Workspace
  3. Click on the workspace connected to QBO
  4. Click Accounting > Export
  5. Click Export company cards as
  6. Observe the hint text for Default vendor

Expected Result:

Hint text is below the toggle

Actual Result:

Incorrect toggle row style for Default vendor

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
CleanShot 2024-06-04 at 10 08 17@2x

Snip - (50) New Expensify - Google Chrome

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a3aa3987291c1ed6
  • Upwork Job ID: 1802761589599110203
  • Last Price Increase: 2024-06-17
  • Automatic offers:
    • ikevin127 | Reviewer | 102780674
    • truph01 | Contributor | 102780677
Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 13, 2024
  2. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. shawnborton commented on Jun 13, 2024

    @shawnborton
    Contributor
  4. truph01 commented on Jun 13, 2024

    @truph01
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Incorrect toggle row style for Default vendor

    What is the root cause of that problem?

    What changes do you think we should make in order to solve the problem?

    • We should use ToggleSettingOptionRow with shouldPlaceSubtitleBelowSwitch: true

    What alternative solutions did you explore? (Optional)

    Result

    image

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 17, 2024
  6. changed the title [-]QBO-incorrect toggle row style for Default vendor[/-] [+][$250] QBO-incorrect toggle row style for Default vendor[/+] on Jun 17, 2024
  7. melvin-bot commented on Jun 17, 2024

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 17, 2024
  9. melvin-bot commented on Jun 17, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

  10. 15 remaining items

  11. changed the title [-][$250] QBO-incorrect toggle row style for Default vendor[/-] [+][HOLD for payment 2024-07-02] [$250] QBO-incorrect toggle row style for Default vendor[/+] on Jun 25, 2024
  12. melvin-bot commented on Jun 25, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jun 25, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-02. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Jun 25, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
    • [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ikevin127] Determine if we should create a regression test for this bug.
    • [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. abekkala commented on Jun 26, 2024

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR JULY 02

  16. ikevin127 commented on Jun 27, 2024

    @ikevin127
    Contributor

    Regression Test Proposal

    Precondition:

    • Workspace is connected to QBO accounting.
    1. Click Settings > Workspace.
    2. Click on the workspace connected to QBO.
    3. Click Accounting > Export.
    4. Click Export company cards as.
    5. Verify that the hint text for Default vendor is below the switch toggle.

    Do we agree 👍 or 👎.

  17. abekkala commented on Jul 2, 2024

    @abekkala
    Contributor

    @truph01 and @ikevin127 payments sent and contracts ended - thank you! 🎉

  18. changed the title [-][HOLD for payment 2024-07-02] [$250] QBO-incorrect toggle row style for Default vendor[/-] [+][HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] QBO-incorrect toggle row style for Default vendor[/+] on Jul 3, 2024
  19. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-10. 🎊

    For reference, here are some details about the assignees on this issue:

  20. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
    • [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ikevin127] Determine if we should create a regression test for this bug.
    • [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions