You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-24] [$250] [One expense reports] Red dot on LHN does not appear for participant when create 1:1 hold expense #43760
@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Hold - Red dot on LHN does not appear for participant when create 1:1 hold expense[/-][+][$250] Hold - Red dot on LHN does not appear for participant when create 1:1 hold expense[/+]on Jun 17, 2024
@lschurr Based on this comment it seems only for the submitter we are showing Red dot(RBR) in LHN. Would like to confirm the expected result here.
cc: @cead22
changed the title [-][$250] [One expense reports] Red dot on LHN does not appear for participant when create 1:1 hold expense[/-][+][HOLD for payment 2024-07-24] [$250] [One expense reports] Red dot on LHN does not appear for participant when create 1:1 hold expense[/+]on Jul 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
[@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Pujan92] Determine if we should create a regression test for this bug.
[@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jun 14, 2024
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Jun 14, 2024
@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
truph01 commentedon Jun 14, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Red dot on LHN does not appear for participant when create 1:1 hold expense
What is the root cause of that problem?
falsein this logic:App/src/libs/ReportUtils.ts
Lines 5278 to 5280 in 75c104b
if the current user is not submitter, that leads to there is no RBR displays for participant when creating 1:1 hold expense.
What changes do you think we should make in order to solve the problem?
getOrderedReportIDsto make sure with the oneTransactionReport will be pinned if its transaction has violations.App/src/libs/SidebarUtils.ts
Lines 95 to 96 in 4622e19
to:
getOptionDatafunction to make sure the RBR is displayed in oneTransactionReport in LHN if its transaction has violations.App/src/libs/SidebarUtils.ts
Line 278 in 4622e19
to:
What alternative solutions did you explore? (Optional)
App/src/libs/ReportUtils.ts
Lines 5278 to 5280 in 75c104b
to:
[-]Hold - Red dot on LHN does not appear for participant when create 1:1 hold expense[/-][+][$250] Hold - Red dot on LHN does not appear for participant when create 1:1 hold expense[/+]melvin-bot commentedon Jun 17, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0161264d9154f7a521
melvin-bot commentedon Jun 17, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (
External)Pujan92 commentedon Jun 19, 2024
@lschurr Based on this comment it seems only for the submitter we are showing Red dot(RBR) in LHN. Would like to confirm the expected result here.
cc: @cead22
36 remaining items
[-][$250] [One expense reports] Red dot on LHN does not appear for participant when create 1:1 hold expense[/-][+][HOLD for payment 2024-07-24] [$250] [One expense reports] Red dot on LHN does not appear for participant when create 1:1 hold expense[/+]melvin-bot commentedon Jul 17, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-24. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 17, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Pujan92 commentedon Jul 24, 2024
We don't have an offending PR here as it is kind of a new thing for the one expense report.
Regression Test Steps
Do you agree 👍 or 👎 ?
lschurr commentedon Jul 24, 2024
Payment summary:
JmillsExpensify commentedon Jul 25, 2024
$250 approved for @Pujan92