Skip to content

[PAID] [VIP][Travel] handle errors when spotnana token isn't created #43780

Closed

Description

@rushatgabhane

Coming from #43081 (comment)

We should handle errors by showing a RBR when spotnana token can't be generated.
Do a pre-design for how errors should be handled, and then implement it.

2 - Make sure to do the same for AcceptSpotnanaTerms command

src/libs/actions/Travel.ts

Issue OwnerCurrent Issue Owner: @rushatgabhane

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 14, 2024
  2. melvin-bot commented on Jun 14, 2024

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. rushatgabhane commented on Jun 16, 2024

    @rushatgabhane
    MemberAuthor

    @strepanier03 please assign this issue to me

  4. melvin-bot commented on Jun 17, 2024

    @melvin-bot

    @strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. strepanier03 commented on Jun 19, 2024

    @strepanier03
    Contributor

    Assigned!

  6. rushatgabhane commented on Jun 23, 2024

    @rushatgabhane
    MemberAuthor

    no updates yet

  7. rushatgabhane commented on Jun 26, 2024

    @rushatgabhane
    MemberAuthor

    PR hit staging

  8. melvin-bot commented on Jun 28, 2024

    @melvin-bot

    @strepanier03 @rushatgabhane this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  9. 17 remaining items

  10. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
    • [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@rushatgabhane] Determine if we should create a regression test for this bug.
    • [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. melvin-bot commented on Aug 14, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@strepanier03)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. strepanier03 commented on Aug 15, 2024

    @strepanier03
    Contributor

    @rushatgabhane - I'll check in later for the checklist.

  13. strepanier03 commented on Aug 20, 2024

    @strepanier03
    Contributor

    Friendly bump on the checklist so we can wrap this one up.

  14. melvin-bot commented on Aug 20, 2024

    @melvin-bot

    @strepanier03, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...

  15. rushatgabhane commented on Aug 21, 2024

    @rushatgabhane
    MemberAuthor
    1. The PR that introduced the bug has been identified. Link to the PR: N.A. this was planned to be handled later

    2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.

    3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

    4. Determine if we should create a regression test for this bug. Yes

    5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

         1. Go to a new account that is on travel beta
         2. Green `+` > Book travel
         3. Click book travel
         4. Accept spotnana term
         5. Verify that if an error happens due to any reason like API being down, an error message is shown.
      
  16. JmillsExpensify commented on Aug 22, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @rushatgabhane

  17. changed the title [-][HOLD for payment 2024-08-14] [VIP][Travel] handle errors when spotnana token isn't created[/-] [+][PAID] [VIP][Travel] handle errors when spotnana token isn't created[/+] on Aug 23, 2024
  18. strepanier03 commented on Aug 23, 2024

    @strepanier03
    Contributor

    REg test created and request is paid, closing now.

  19. moved this from Low - Everything else to Done in [#whatsnext] #Travelon Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions