You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[PAID] [VIP][Travel] handle errors when spotnana token isn't created #43780
We should handle errors by showing a RBR when spotnana token can't be generated.
Do a pre-design for how errors should be handled, and then implement it.
2 - Make sure to do the same for AcceptSpotnanaTerms command
@strepanier03@rushatgabhane this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
[@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rushatgabhane] Determine if we should create a regression test for this bug.
[@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR: N.A. this was planned to be handled later
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again
1. Go to a new account that is on travel beta
2. Green `+` > Book travel
3. Click book travel
4. Accept spotnana term
5. Verify that if an error happens due to any reason like API being down, an error message is shown.
changed the title [-][HOLD for payment 2024-08-14] [VIP][Travel] handle errors when spotnana token isn't created[/-][+][PAID] [VIP][Travel] handle errors when spotnana token isn't created[/+]on Aug 23, 2024
Activity
melvin-bot commentedon Jun 14, 2024
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.rushatgabhane commentedon Jun 16, 2024
@strepanier03 please assign this issue to me
melvin-bot commentedon Jun 17, 2024
@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
strepanier03 commentedon Jun 19, 2024
Assigned!
rushatgabhane commentedon Jun 23, 2024
no updates yet
rushatgabhane commentedon Jun 26, 2024
PR hit staging
melvin-bot commentedon Jun 28, 2024
@strepanier03 @rushatgabhane this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
17 remaining items
melvin-bot commentedon Aug 7, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Aug 14, 2024
Payment Summary
Upwork Job
BugZero Checklist (@strepanier03)
strepanier03 commentedon Aug 15, 2024
@rushatgabhane - I'll check in later for the checklist.
strepanier03 commentedon Aug 20, 2024
Friendly bump on the checklist so we can wrap this one up.
melvin-bot commentedon Aug 20, 2024
@strepanier03, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...
rushatgabhane commentedon Aug 21, 2024
The PR that introduced the bug has been identified. Link to the PR: N.A. this was planned to be handled later
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again
JmillsExpensify commentedon Aug 22, 2024
$250 approved for @rushatgabhane
[-][HOLD for payment 2024-08-14] [VIP][Travel] handle errors when spotnana token isn't created[/-][+][PAID] [VIP][Travel] handle errors when spotnana token isn't created[/+]strepanier03 commentedon Aug 23, 2024
REg test created and request is paid, closing now.