You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Expensify chat - Incorrect LHN preview for Expensify chat #43830
Version Number: 1.4.84-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to Expensify chat
Expected Result:
Expensify chat preview in LHN should display "Welcome! Let's get you set up." or "Message Concierge for help with setup"
Actual Result:
Expensify chat preview in LHN displays "This is the beginning of your chat with Expensify"
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-] Expensify chat - Incorrect LHN preview for Expensify chat[/-][+][$250] Expensify chat - Incorrect LHN preview for Expensify chat[/+]on Jun 19, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@suneox / @ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:
[@suneox / @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@suneox / @ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@suneox / @ZhenjaHorbach] Determine if we should create a regression test for this bug.
[@suneox / @ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@suneox / @ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:
[@suneox / @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@suneox / @ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
NA
[@suneox / @ZhenjaHorbach] Determine if we should create a regression test for this bug.
I'm not sure we need a regression test for this bug since it's a very minor issue.
[@suneox / @ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Jun 17, 2024
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Jun 17, 2024
@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jun 17, 2024
We think that this bug might be related to #vip-vsp
JmillsExpensify commentedon Jun 19, 2024
Opening up to the community. This is a #vip-vsb initiative.
[-] Expensify chat - Incorrect LHN preview for Expensify chat[/-][+][$250] Expensify chat - Incorrect LHN preview for Expensify chat[/+]melvin-bot commentedon Jun 19, 2024
Job added to Upwork: https://www.upwork.com/jobs/~016857ff3bf2660def
38 remaining items
[-][HOLD for payment 2024-07-17] [$250] Expensify chat - Incorrect LHN preview for Expensify chat[/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Expensify chat - Incorrect LHN preview for Expensify chat[/+]melvin-bot commentedon Jul 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 15, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
ZhenjaHorbach commentedon Jul 17, 2024
#41290
https://github.com/Expensify/App/pull/41290/files#r1680686700
NA
I'm not sure we need a regression test for this bug since it's a very minor issue.
NA
melvin-bot commentedon Jul 19, 2024
@JmillsExpensify, @suneox, @grgia, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
ZhenjaHorbach commentedon Jul 22, 2024
Not overdue
@JmillsExpensify
Waiting for payment !
Can you help with that, please ?
melvin-bot commentedon Jul 23, 2024
@JmillsExpensify, @suneox, @grgia, @ZhenjaHorbach Still overdue 6 days?! Let's take care of this!
JmillsExpensify commentedon Jul 23, 2024
Payment summary:
Contributor: @suneox $250
Reviewer: @ZhenjaHorbach $250
JmillsExpensify commentedon Jul 23, 2024
Both contributors paid via Upwork. Closing!