Skip to content

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Expensify chat - Incorrect LHN preview for Expensify chat #43830

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.84-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Expensify chat

Expected Result:

Expensify chat preview in LHN should display "Welcome! Let's get you set up." or "Message Concierge for help with setup"

Actual Result:

Expensify chat preview in LHN displays "This is the beginning of your chat with Expensify"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6514462_1718473042888.expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016857ff3bf2660def
  • Upwork Job ID: 1803535142361593535
  • Last Price Increase: 2024-06-26
  • Automatic offers:
    • ZhenjaHorbach | Reviewer | 102959045
    • suneox | Contributor | 102959046
Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 17, 2024
  2. melvin-bot commented on Jun 17, 2024

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Jun 17, 2024

    @lanitochka17
    Author

    @JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Jun 17, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  5. JmillsExpensify commented on Jun 19, 2024

    @JmillsExpensify
    Contributor

    Opening up to the community. This is a #vip-vsb initiative.

  6. changed the title [-] Expensify chat - Incorrect LHN preview for Expensify chat[/-] [+][$250] Expensify chat - Incorrect LHN preview for Expensify chat[/+] on Jun 19, 2024
  7. melvin-bot commented on Jun 19, 2024

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 19, 2024
  9. 38 remaining items

  10. changed the title [-][HOLD for payment 2024-07-17] [$250] Expensify chat - Incorrect LHN preview for Expensify chat[/-] [+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Expensify chat - Incorrect LHN preview for Expensify chat[/+] on Jul 15, 2024
  11. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-22. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@suneox / @ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:
    • [@suneox / @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@suneox / @ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@suneox / @ZhenjaHorbach] Determine if we should create a regression test for this bug.
    • [@suneox / @ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. ZhenjaHorbach commented on Jul 17, 2024

    @ZhenjaHorbach
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    #41290

    • [@suneox / @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    https://github.com/Expensify/App/pull/41290/files#r1680686700

    • [@suneox / @ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    NA

    I'm not sure we need a regression test for this bug since it's a very minor issue.

    NA

  14. melvin-bot commented on Jul 19, 2024

    @melvin-bot

    @JmillsExpensify, @suneox, @grgia, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. ZhenjaHorbach commented on Jul 22, 2024

    @ZhenjaHorbach
    Contributor

    Not overdue

    @JmillsExpensify
    Waiting for payment !
    Can you help with that, please ?

  16. melvin-bot commented on Jul 23, 2024

    @melvin-bot

    @JmillsExpensify, @suneox, @grgia, @ZhenjaHorbach Still overdue 6 days?! Let's take care of this!

  17. JmillsExpensify commented on Jul 23, 2024

    @JmillsExpensify
    Contributor

    Payment summary:

    Contributor: @suneox $250
    Reviewer: @ZhenjaHorbach $250

  18. JmillsExpensify commented on Jul 23, 2024

    @JmillsExpensify
    Contributor

    Both contributors paid via Upwork. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions