You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Task – Hidden appears as task assignee for user B when user A create a task without assignee #43833
Log in as user B (relogin if you are login already)
Open group chat from step 3 and find the task from step 4
Expected Result:
Task without assignee is present in group chat after relogin
Actual Result:
Hidden appears as task assignee for user B in group chat after relogin when user A create a task without assignee. When open task details assignee is not selected. The same for task in room.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Please re-state the problem that we are trying to solve in this issue.
Hidden appears as task assignee for user B in group chat after relogin when user A create a task without assignee. When open task details assignee is not selected. The same for task in room.
What is the root cause of that problem?
When user B login or user A re-login, the taskReport.managerID and action?.childManagerAccountID are undefined so taskAssigneeAccountID fallbacks to -1 and then Hidden appears. In the past, we fallback the taskAssigneeAccountID as an empty string, and when user A creates the task the optimistic assignAccountID is 0 so this bug doesn't happen.
changed the title [-][$250] Task – Hidden appears as task assignee for user B when user A create a task without assignee[/-][+]Task – Hidden appears as task assignee for user B when user A create a task without assignee[/+]on Jun 21, 2024
Activity
melvin-bot commentedon Jun 17, 2024
Triggered auto assignment to @grgia (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 17, 2024
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jun 17, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
kavimuru commentedon Jun 17, 2024
@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
kavimuru commentedon Jun 17, 2024
We think this bug might be related to #vip-vsb
grgia commentedon Jun 17, 2024
What's the expected result here? @kavimuru
11 remaining items
grgia commentedon Jun 17, 2024
Making external for now, but looks like there's a chance it could be an internal issue
nkdengineer commentedon Jun 18, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Hidden appears as task assignee for user B in group chat after relogin when user A create a task without assignee. When open task details assignee is not selected. The same for task in room.
What is the root cause of that problem?
When user B login or user A re-login, the
taskReport.managerIDandaction?.childManagerAccountIDareundefinedsotaskAssigneeAccountIDfallbacks to-1and thenHiddenappears. In the past, we fallback thetaskAssigneeAccountIDas an empty string, and when user A creates the task the optimisticassignAccountIDis0so this bug doesn't happen.App/src/components/ReportActionItem/TaskPreview.tsx
Lines 75 to 77 in b335423
What changes do you think we should make in order to solve the problem?
Remove the fallback
-1here so we will not show the task assignee if it doesn't existApp/src/components/ReportActionItem/TaskPreview.tsx
Line 75 in b335423
Or we can update this condition to not show the task assign if
taskAssigneeAccountIDis-1or0https://github.com/Expensify/App/blob/b33542383ac2cb8ea1e922aa12dd2265efccd0ab/src/components/ReportActionItem/TaskPreview.tsx#L75-77
OPTIONAL: We can also set the default value of
assigneeAccountIDhere asundefinedto be consistent with back-endApp/src/libs/actions/Task.ts
Line 119 in b335423
What alternative solutions did you explore? (Optional)
bernhardoj commentedon Jun 18, 2024
This is going to be fixed in #43646
grgia commentedon Jun 18, 2024
@bernhardoj in that case, can you please add these steps to the test steps/QA steps for your PR #43646
bernhardoj commentedon Jun 19, 2024
PR is merged, I think we can ask QA to retest this issue.
melvin-bot commentedon Jun 20, 2024
@garrettmknight, @grgia, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-][$250] Task – Hidden appears as task assignee for user B when user A create a task without assignee[/-][+]Task – Hidden appears as task assignee for user B when user A create a task without assignee[/+]grgia commentedon Jun 21, 2024
@kavimuru could you please retest this on staging?
kavimuru commentedon Jun 21, 2024
@grgia Retested and not able to reproduce by the tester.
Screenrecorder-2024-06-21-16-35-43-278.mp4
grgia commentedon Jun 21, 2024
Thank you @kavimuru , closing!