Skip to content

[HOLD for payment 2024-08-09] [$250] Mention List - Users are not alphabetically ordered #43845

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.84-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+mentiont1@applause.expensifail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #42553

Action Performed:

Precondition: Sign in with a high-trafic account. Create a workspace room and group. Then invite the following users natnael.expensify+idf6yd@gmail.com,
natnael.expensify+lajf088b@gmail.com,
natnael.expensify+ldjf66vd@gmail.com,
natnael.expensify+3@gmail.com
to the group and the room. The accounts are set up for this test.

  1. Navigate to the the workspace room chat > type @
  2. Navigate to the group chat > type @

Expected Result:

Users should be listed alphabetically on mention list as thy are on members page

Actual Result:

User name that starts with upper case comes before user names that stars with lower case even if they shouldn't if ordered alphabetically

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6515945_1718635610359.Screen_Recording_2024-06-17_at_5.37.44_in_the_afternoon.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c4e1646d5e188fdf
  • Upwork Job ID: 1802726751851213312
  • Last Price Increase: 2024-07-08
  • Automatic offers:
    • situchan | Reviewer | 103067158
    • dominictb | Contributor | 103067159
Issue OwnerCurrent Issue Owner: @cead22

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 17, 2024
  2. melvin-bot commented on Jun 17, 2024

    @melvin-bot

    Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jun 17, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jun 17, 2024

    @lanitochka17
    Author

    @cead22 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. lanitochka17 commented on Jun 17, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 17, 2024
  7. changed the title [-] Mention List - Users are not alphabetically ordered[/-] [+][$250] Mention List - Users are not alphabetically ordered[/+] on Jun 17, 2024
  8. 47 remaining items

  9. cead22 commented on Jul 23, 2024

    @cead22
    Contributor

    C+ review is still in progress

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 2, 2024
  11. changed the title [-][$250] Mention List - Users are not alphabetically ordered[/-] [+][HOLD for payment 2024-08-09] [$250] Mention List - Users are not alphabetically ordered[/+] on Aug 2, 2024
  12. melvin-bot commented on Aug 2, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Aug 2, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-09. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Aug 9, 2024

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @OfstadC you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  15. OfstadC commented on Aug 9, 2024

    @OfstadC
    Contributor

    Payment Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions