Skip to content

[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-28] App crashes when Ctrl/Cmd + D is pressed #43897

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


issue found when validating #43543
Version Number: 1.4.85-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Sign in to Expensify.
  2. Press Ctrl/Cmd + D.

Expected Result:

Pressing Ctrl/Cmd + D should not cause the app to crash instead it should open the troubleshooting model

Actual Result:

The app crashes when pressing Ctrl/Cmd + D

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6516839_1718697002915.Screen_Recording_2024-06-18_at_12.27.46_AM.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @greg-schroeder

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 18, 2024
  2. melvin-bot commented on Jun 18, 2024

    @melvin-bot

    Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jun 18, 2024

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Jun 18, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Jun 18, 2024

    @m-natarajan
    Author

    @greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. dangrous commented on Jun 18, 2024

    @dangrous
    Contributor

    This is definitely going to be front end, removing Deploy Blocker label

    But it's also not consistently reproducible - for example I just tried it on staging and it crashed the first time, but not after that. Haven't managed to trigger it on local yet.

    (That's not saying it's not a bug, it definitely is, but finding the cause will be slightly more challenging)

  7. 15 remaining items

  8. dangrous commented on Jun 20, 2024

    @dangrous
    Contributor

    Okay great! Thanks for the assist @Beamanator. Closing now.

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 21, 2024
  10. changed the title [-]App crashes when Ctrl/Cmd + D is pressed[/-] [+][HOLD for payment 2024-06-28] App crashes when Ctrl/Cmd + D is pressed[/+] on Jun 21, 2024
  11. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-28. 🎊

  13. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@dangrous] The PR that introduced the bug has been identified. Link to the PR:
    • [@dangrous] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@dangrous] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@dangrous] Determine if we should create a regression test for this bug.
    • [@dangrous] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. changed the title [-][HOLD for payment 2024-06-28] App crashes when Ctrl/Cmd + D is pressed[/-] [+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-28] App crashes when Ctrl/Cmd + D is pressed[/+] on Jun 21, 2024
  15. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-28. 🎊

  16. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@dangrous] The PR that introduced the bug has been identified. Link to the PR:
    • [@dangrous] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@dangrous] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@dangrous] Determine if we should create a regression test for this bug.
    • [@dangrous] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions