You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for Payment] [$125] Settings - Wrong index when pressing Tab button in the Save the world section #43991
Please re-state the problem that we are trying to solve in this issue.
Wrong index when pressing Tab button in the Save the world section
What is the root cause of that problem?
The save the world page is not listed on the WIDE_LAYOUT_INACTIVE_SCREENS as the other screens. And because of that, the focus trap is used there and focusing maily on the 1st element. Clicking on tab will automaticly switch to the second tab
changed the title [-] Settings - Wrong index when pressing Tab button in the Save the world section[/-][+][$250] Settings - Wrong index when pressing Tab button in the Save the world section[/+]on Jun 21, 2024
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
We will pay out the full amount for this issue. @devguest07 could you please apply to the Upwork job or share your Upwork profile so that I can send you an offer? Thanks!
changed the title [-][$125] Settings - Wrong index when pressing Tab button in the Save the world section[/-][+][HOLD for Payment] [$125] Settings - Wrong index when pressing Tab button in the Save the world section[/+]on Jul 24, 2024
Activity
melvin-bot commentedon Jun 19, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.devguest07 commentedon Jun 19, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Wrong index when pressing Tab button in the Save the world section
What is the root cause of that problem?
The save the world page is not listed on the WIDE_LAYOUT_INACTIVE_SCREENS as the other screens. And because of that, the focus trap is used there and focusing maily on the 1st element. Clicking on tab will automaticly switch to the second tab
App/src/components/FocusTrap/WIDE_LAYOUT_INACTIVE_SCREENS.ts
Line 5 in af9be0a
What changes do you think we should make in order to solve the problem?
The save the world page should be also listed on WIDE_LAYOUT_INACTIVE_SCREENS as the other screens
App/src/components/FocusTrap/WIDE_LAYOUT_INACTIVE_SCREENS.ts
Lines 14 to 16 in af9be0a
sakluger commentedon Jun 21, 2024
We should probably fix this for accessibility consistency, but it's such a small issue so I'm going to reduce the payout to $125.
[-] Settings - Wrong index when pressing Tab button in the Save the world section[/-][+][$250] Settings - Wrong index when pressing Tab button in the Save the world section[/+]melvin-bot commentedon Jun 21, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01e452205241cde504
melvin-bot commentedon Jun 21, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)19 remaining items
melvin-bot commentedon Jul 22, 2024
This issue has not been updated in over 15 days. @cead22, @sakluger, @s77rt, @devguest07 eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
s77rt commentedon Jul 22, 2024
Should we close this one? The bug has been fixed by another PR
sakluger commentedon Jul 24, 2024
Sorry for the delay, I missed this one entirely.
I'm going to check with my team to see if we should compensate for the work done here.
sakluger commentedon Jul 24, 2024
We will pay out the full amount for this issue. @devguest07 could you please apply to the Upwork job or share your Upwork profile so that I can send you an offer? Thanks!
[-][$125] Settings - Wrong index when pressing Tab button in the Save the world section[/-][+][HOLD for Payment] [$125] Settings - Wrong index when pressing Tab button in the Save the world section[/+]sakluger commentedon Jul 24, 2024
Summarizing payment on this issue:
Contributor: @devguest07 $125, payable via Upwork (No offer yet)
Contributor+: @s77rt $125, please request on Newdot
JmillsExpensify commentedon Jul 25, 2024
$125 approved for @s77rt
sakluger commentedon Jul 25, 2024
Found @devguest07's Upwork profile and sent an offer: https://www.upwork.com/nx/wm/offer/103264866.
@devguest07 please let me know once you've accepted the offer so I can complete the payment and close the GH issue. Thank you!
devguest07 commentedon Jul 25, 2024
@sakluger offer accepted. Thank you
sakluger commentedon Jul 26, 2024
Thanks! All paid 👍