Skip to content

[HOLD for Payment] [$125] Settings - Wrong index when pressing Tab button in the Save the world section #43991

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.85-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): crowdtest.expensify+test002@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Open the app
  2. Go to Account Settings
  3. Tap on Save the World
  4. Press the Tab on the keyboard

Expected Result:

"I am a teacher" should selected when pressing a first Tab

Actual Result:

Wrong index when tapping the Tab button in the Save the world section, "I am a teacher" first selected instead "I know a teacher"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6518369_1718800542339.Screen_Recording_2024-06-19_at_09.01.05.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e452205241cde504
  • Upwork Job ID: 1804295779857100557
  • Last Price Increase: 2024-06-21
  • Automatic offers:
    • s77rt | Reviewer | 102862296
Issue OwnerCurrent Issue Owner: @s77rt

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 19, 2024
  2. melvin-bot commented on Jun 19, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. devguest07 commented on Jun 19, 2024

    @devguest07
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Wrong index when pressing Tab button in the Save the world section

    What is the root cause of that problem?

    The save the world page is not listed on the WIDE_LAYOUT_INACTIVE_SCREENS as the other screens. And because of that, the focus trap is used there and focusing maily on the 1st element. Clicking on tab will automaticly switch to the second tab

    const WIDE_LAYOUT_INACTIVE_SCREENS: string[] = [

    What changes do you think we should make in order to solve the problem?

    The save the world page should be also listed on WIDE_LAYOUT_INACTIVE_SCREENS as the other screens

    SCREENS.SETTINGS.ABOUT,
    SCREENS.SETTINGS.WORKSPACES,
    SCREENS.SETTINGS.SUBSCRIPTION.ROOT,

  4. sakluger commented on Jun 21, 2024

    @sakluger
    Contributor

    We should probably fix this for accessibility consistency, but it's such a small issue so I'm going to reduce the payout to $125.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 21, 2024
  6. changed the title [-] Settings - Wrong index when pressing Tab button in the Save the world section[/-] [+][$250] Settings - Wrong index when pressing Tab button in the Save the world section[/+] on Jun 21, 2024
  7. melvin-bot commented on Jun 21, 2024

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 21, 2024
  9. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

  10. 19 remaining items

  11. melvin-bot commented on Jul 22, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @cead22, @sakluger, @s77rt, @devguest07 eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  12. s77rt commented on Jul 22, 2024

    @s77rt
    Member

    Should we close this one? The bug has been fixed by another PR

  13. sakluger commented on Jul 24, 2024

    @sakluger
    Contributor

    Sorry for the delay, I missed this one entirely.

    I'm going to check with my team to see if we should compensate for the work done here.

  14. sakluger commented on Jul 24, 2024

    @sakluger
    Contributor

    We will pay out the full amount for this issue. @devguest07 could you please apply to the Upwork job or share your Upwork profile so that I can send you an offer? Thanks!

  15. changed the title [-][$125] Settings - Wrong index when pressing Tab button in the Save the world section[/-] [+][HOLD for Payment] [$125] Settings - Wrong index when pressing Tab button in the Save the world section[/+] on Jul 24, 2024
  16. sakluger commented on Jul 24, 2024

    @sakluger
    Contributor

    Summarizing payment on this issue:

    Contributor: @devguest07 $125, payable via Upwork (No offer yet)
    Contributor+: @s77rt $125, please request on Newdot

  17. JmillsExpensify commented on Jul 25, 2024

    @JmillsExpensify
    Contributor

    $125 approved for @s77rt

  18. sakluger commented on Jul 25, 2024

    @sakluger
    Contributor

    Found @devguest07's Upwork profile and sent an offer: https://www.upwork.com/nx/wm/offer/103264866.

    @devguest07 please let me know once you've accepted the offer so I can complete the payment and close the GH issue. Thank you!

  19. devguest07 commented on Jul 25, 2024

    @devguest07
    Contributor

    @sakluger offer accepted. Thank you

  20. sakluger commented on Jul 26, 2024

    @sakluger
    Contributor

    Thanks! All paid 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions