You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-13] [$250] Context menu - Unable to add reaction by Enter key/navigate from first option to last by up key #44095
Version Number: 1.4.86-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/4647677 Issue reported by: Applause - Internal Team
Action Performed:
Log in to New Expensify
Navigate to any chat
Right click on any message
Press Tab key
Press Enter
Press down arrow key
Press up arrow key
Expected Result:
In step 5., The highlighted emoji should be added as reaction to the message (works well for hover menu)
In step 7., User should be able to navigate from first highlighted option to the last one using arrow keys
Actual Result:
Step 5. Nothing happens user is unable to add reaction or open emoji picker using Enter key in context menu.
Step 7. Option does not change, user is unable to navigate from first option to last by up arrow key and from last to first by down arrow key
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Context menu - Unable to add reaction by Enter key/navigate from first option to last by up key[/-][+][$250] Context menu - Unable to add reaction by Enter key/navigate from first option to last by up key[/+]on Jun 25, 2024
changed the title [-][$250] Context menu - Unable to add reaction by Enter key/navigate from first option to last by up key[/-][+][HOLD for payment 2024-08-13] [$250] Context menu - Unable to add reaction by Enter key/navigate from first option to last by up key[/+]on Aug 6, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.16-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
[@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@dukenv0307] Determine if we should create a regression test for this bug.
[@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR: N/A
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Jun 20, 2024
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Jun 20, 2024
@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Krishna2323 commentedon Jun 20, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Context menu - Unable to add reaction by Enter key/navigate from first option to last by up key
What is the root cause of that problem?
In
BaseReportActionContextMenu, we are usinguseKeyboardShortcutwhich prevents default due to which the event is not captured by the pressable.App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx
Lines 188 to 204 in 5bccd00
Cyclically traverse is disabled intentionally in this PR
App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx
Line 169 in 896c14c
What changes do you think we should make in order to solve the problem?
We should add
shouldPreventDefault: falsein theKeyboardShortcutConfig.App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx
Line 203 in 5bccd00
What alternative solutions did you explore? (Optional)
gijoe0295 commentedon Jun 20, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx
Lines 188 to 189 in 45a3c12
disableCyclicTraversal:App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx
Line 169 in 45a3c12
What changes do you think we should make in order to solve the problem?
shouldPreventDefault: falseto the keyboard handler abovedisableCyclicTraversal: truefrom the arrow key handler abovebernhardoj commentedon Jun 21, 2024
The cyclic traversal is being discussed here
melvin-bot commentedon Jun 25, 2024
@abekkala Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Jun 25, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01f3361b27929e9c6b
[-]Context menu - Unable to add reaction by Enter key/navigate from first option to last by up key[/-][+][$250] Context menu - Unable to add reaction by Enter key/navigate from first option to last by up key[/+]melvin-bot commentedon Jun 25, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (
External)44 remaining items
roryabraham commentedon Aug 2, 2024
@francoisl assigning to you since you reviewed the PR.
[-][$250] Context menu - Unable to add reaction by Enter key/navigate from first option to last by up key[/-][+][HOLD for payment 2024-08-13] [$250] Context menu - Unable to add reaction by Enter key/navigate from first option to last by up key[/+]melvin-bot commentedon Aug 6, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 6, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.16-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 6, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
abekkala commentedon Aug 7, 2024
PAYMENT SUMMARY FOR AUG 13, if no regressions
Please complete checklist
dukenv0307 commentedon Aug 8, 2024
BugZero Checklist:
Regression tests:
Do we 👍 or 👎
abekkala commentedon Aug 13, 2024
@Krishna2323 and @dukenv0307 payment sent and contract ended - thank you! 🎉