You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Room - Room chat LHN preview displays "removed 0 user" after editing room description #44194
Version Number: 9.0.1-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to any room chat
Click on the chat header
Click Room description
Edit room description and save it
Wait for the room description system message to show up in the chat
Look at the room chat LHN preview
Expected Result:
Room chat LHN preview will display room description edit system message
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@cristipaval FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Here we are missing the logic to check lastActionName === 'UPDATEROOMDESCRIPTION' and we dont handle the case to set result.alternateText appropriate transalation key. (set room description to: {newroomName} )
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Issue is ready for payment but no BZ is assigned. @miljakljajic you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
github-actions commentedon Jun 22, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jun 22, 2024
Triggered auto assignment to @cristipaval (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Jun 22, 2024
@cristipaval FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jun 22, 2024
We think that this bug might be related to #vip-vsp
ishpaul777 commentedon Jun 22, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Room chat LHN preview displays "removed 0 user" after editing room description
What is the root cause of that problem?
Here we are missing the logic to check lastActionName === 'UPDATEROOMDESCRIPTION' and we dont handle the case to set
result.alternateTextappropriate transalation key. (set room description to: {newroomName} )App/src/libs/SidebarUtils.ts
Lines 352 to 361 in 425804a
What changes do you think we should make in order to solve the problem?
we need to check lastActionName === 'UPDATEROOMDESCRIPTION' and set
result.alternateTextto appropriate translation keyApp/src/libs/SidebarUtils.ts
Lines 352 to 361 in 425804a
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
mountiny commentedon Jun 24, 2024
@ishpaul777 What PR cause this regression?
ishpaul777 commentedon Jun 24, 2024
This one #40168
cristipaval commentedon Jun 24, 2024
@nkdengineer, do you have time to look at this one?
21 remaining items
[-][$250] Room - Room chat LHN preview displays "removed 0 user" after editing room description[/-][+][HOLD for payment 2024-07-02] [$250] Room - Room chat LHN preview displays "removed 0 user" after editing room description[/+]melvin-bot commentedon Jun 25, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 2, 2024
Issue is ready for payment but no BZ is assigned. @miljakljajic you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
miljakljajic commentedon Jul 3, 2024
both contributors paid. Thank you!
[-][HOLD for payment 2024-07-02] [$250] Room - Room chat LHN preview displays "removed 0 user" after editing room description[/-][+][HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Room - Room chat LHN preview displays "removed 0 user" after editing room description[/+]melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
For reference, here are some details about the assignees on this issue: