Skip to content

[HOLD for payment 2024-07-25] [$250] Expense - Tapping back button after deleting expense leads to not here page #44199

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.1-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Launch New Expensify app.
  2. Submit two manual expenses to any user.
  3. Go to transaction thread of any expenses.
  4. Tap on the report header.
  5. Tap Delete expense.
  6. Delete the expense.
  7. Tap on the back button on the top left.

Expected Result:

App will return to the main page.

Actual Result:

App shows long skeleton loading and then not here page loads.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6521360_1719047106407.RPReplay_Final1719038925.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0149255b2b8a3385dc
  • Upwork Job ID: 1805204830810844307
  • Last Price Increase: 2024-06-24
Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 22, 2024
  2. melvin-bot commented on Jun 22, 2024

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 22, 2024

    @melvin-bot

    Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Jun 22, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Jun 22, 2024

    @m-natarajan
    Author

    @CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. m-natarajan commented on Jun 22, 2024

    @m-natarajan
    Author

    We think that this bug might be related to #wave-collect - Release 1

  7. 65 remaining items

  8. CortneyOfstad commented on Jul 24, 2024

    @CortneyOfstad
    Contributor

    @allroundexperts can you have the checklist completed before EOD tomorrow? This will help avoid any delay in payment — thank you!

  9. melvin-bot commented on Jul 25, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@CortneyOfstad)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1805204830810844307/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  10. CortneyOfstad commented on Jul 25, 2024

    @CortneyOfstad
    Contributor

    @allroundexperts please complete the check list at your earliest convenience! Thank you!

  11. cdOut commented on Jul 29, 2024

    @cdOut
    Contributor

    Hi, I just wanted to confirm, has this issue been properly fixed by this or another issue PR or are there still problems as pointed in this previous comment?

  12. allroundexperts commented on Jul 29, 2024

    @allroundexperts
    Contributor

    Hi, I just wanted to confirm, has this issue been properly fixed by this or another issue PR or are there still problems as pointed in this previous comment?

    The other issue was closed and fix was added here.

  13. allroundexperts commented on Jul 29, 2024

    @allroundexperts
    Contributor

    Checklist

    1. [Details Revamp] Update ReportDetailsPage for Rooms, Groups, Money Reports and Policy Expenses #43251
    2. The author is aware of the issue and helped to review the fix in this issue.
    3. N/A
    4. A regression test would be helpful here.

    Regression test

    1. Open the app and submit two manual expenses to any user.
    2. Go to transaction thread of any expenses.
    3. Tap on the report header and select Delete expense.
    4. Delete the expense.
    5. Tap on the back button on the top left.

    Verify that the app returns to the main page.

    Do we 👍 or 👎 ?

  14. CortneyOfstad commented on Jul 29, 2024

    @CortneyOfstad
    Contributor

    Payment Summary

    @allroundexperts — to be paid $250 via NewDot

    Regression Test

    https://github.com/Expensify/Expensify/issues/416105

  15. JmillsExpensify commented on Oct 4, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions