Skip to content

[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Pay someone - App crashes after paying someone and opening chat header in transaction thread #44201

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any chat
  3. Go to + > Pay
  4. Enter amount > Pay elsewhere
  5. Immediately click on the expense preview and then the chat header after paying the money
  6. Wait until the app crashes

Expected Result:

App will not crash

Actual Result:

App crashes after paying someone and opening chat header in transaction thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6521357_1719047085756.crash.mp4

logs (2).txt

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 22, 2024
  2. github-actions commented on Jun 22, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on Jun 22, 2024

    @melvin-bot

    Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. lanitochka17 commented on Jun 22, 2024

    @lanitochka17
    Author

    @dangrous FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. ishpaul777 commented on Jun 22, 2024

    @ishpaul777
    Contributor

    Offending PR - #43251


    Possible solution to fix crash:
    we need to default parentReportID and reportID to -1 instead of empty string.

    const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID ?? ''}`);
    const [sortedAllReportActions] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID ?? ''}`, {

  6. ikevin127 commented on Jun 23, 2024

    @ikevin127
    Contributor

    cc @cdOut If this is indeed caused by our PR, looks like we missed adding the right fallback value there ^.

  7. dangrous commented on Jun 24, 2024

    @dangrous
    Contributor

    @ikevin127 @cdOut let us know when this is ready for a look!

  8. 8 remaining items

  9. changed the title [-]Pay someone - App crashes after paying someone and opening chat header in transaction thread[/-] [+][HOLD for payment 2024-07-02] Pay someone - App crashes after paying someone and opening chat header in transaction thread[/+] on Jun 25, 2024
  10. melvin-bot commented on Jun 25, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jun 25, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-02. 🎊

  12. melvin-bot commented on Jul 2, 2024

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  13. dangrous commented on Jul 3, 2024

    @dangrous
    Contributor

    Closing this out since payment will be handled in the other regression issue.

  14. changed the title [-][HOLD for payment 2024-07-02] Pay someone - App crashes after paying someone and opening chat header in transaction thread[/-] [+][HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Pay someone - App crashes after paying someone and opening chat header in transaction thread[/+] on Jul 3, 2024
  15. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-10. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions