You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Pay someone - App crashes after paying someone and opening chat header in transaction thread #44201
Version Number: 9.0.1-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to any chat
Go to + > Pay
Enter amount > Pay elsewhere
Immediately click on the expense preview and then the chat header after paying the money
Wait until the app crashes
Expected Result:
App will not crash
Actual Result:
App crashes after paying someone and opening chat header in transaction thread
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@dangrous FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Pay someone - App crashes after paying someone and opening chat header in transaction thread[/-][+][HOLD for payment 2024-07-02] Pay someone - App crashes after paying someone and opening chat header in transaction thread[/+]on Jun 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
changed the title [-][HOLD for payment 2024-07-02] Pay someone - App crashes after paying someone and opening chat header in transaction thread[/-][+][HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Pay someone - App crashes after paying someone and opening chat header in transaction thread[/+]on Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
github-actions commentedon Jun 22, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jun 22, 2024
Triggered auto assignment to @dangrous (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Jun 22, 2024
@dangrous FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
ishpaul777 commentedon Jun 22, 2024
Offending PR - #43251
Possible solution to fix crash:
we need to default
parentReportIDandreportIDto-1instead of empty string.App/src/pages/ReportDetailsPage.tsx
Lines 82 to 83 in 425804a
ikevin127 commentedon Jun 23, 2024
cc @cdOut If this is indeed caused by our PR, looks like we missed adding the right fallback value there ^.
dangrous commentedon Jun 24, 2024
@ikevin127 @cdOut let us know when this is ready for a look!
8 remaining items
[-]Pay someone - App crashes after paying someone and opening chat header in transaction thread[/-][+][HOLD for payment 2024-07-02] Pay someone - App crashes after paying someone and opening chat header in transaction thread[/+]melvin-bot commentedon Jun 25, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-02. 🎊
melvin-bot commentedon Jul 2, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
dangrous commentedon Jul 3, 2024
Closing this out since payment will be handled in the other regression issue.
[-][HOLD for payment 2024-07-02] Pay someone - App crashes after paying someone and opening chat header in transaction thread[/-][+][HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Pay someone - App crashes after paying someone and opening chat header in transaction thread[/+]melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊