Skip to content

[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Track expense - "Join" button appears in report details page when tracking expense in self DM #44202

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause -Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to self DM
  3. Track a manual expense
  4. Go to transaction thread
  5. Click on the chat header

Expected Result:

"Join" button will not appear in report details page

Actual Result:

"Join" button appears in report details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6521415_1719052976119.20240622_184036.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011a02e6fd1b333eff
  • Upwork Job ID: 1805160854935465741
  • Last Price Increase: 2024-06-24
  • Automatic offers:
    • akinwale | Reviewer | 102853800
    • bernhardoj | Contributor | 102853801
    • c3024 | Contributor | 102854334
Issue OwnerCurrent Issue Owner: @twisterdotcom

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 22, 2024
  2. melvin-bot commented on Jun 22, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 22, 2024

    @melvin-bot

    Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Jun 22, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. lanitochka17 commented on Jun 22, 2024

    @lanitochka17
    Author

    @twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. lanitochka17 commented on Jun 22, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  7. bernhardoj commented on Jun 23, 2024

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Join button shows in the track expense report details page.

    What is the root cause of that problem?

    We already hide the join button if it's an expense report.

    const canJoin = !isExpenseReport && ReportUtils.canJoinChat(report, parentReportAction, policy);

    But the expense report only covers invoice, IOU/expense report, and IOU/expense transaction thread.

    const isExpenseReport = isMoneyRequestReport || isInvoiceReport || isMoneyRequest;

    What changes do you think we should make in order to solve the problem?

    Add a new condition to check if it's a track expense report.

    const canJoin = !isExpenseReport && !ReportUtils.isTrackExpenseReport(report) && ReportUtils.canJoinChat(report, parentReportAction, policy);
    

    we can optionally move the condition to canJoinChat

  8. 32 remaining items

  9. melvin-bot commented on Jun 25, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@c3024] The PR that introduced the bug has been identified. Link to the PR:
    • [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@c3024] Determine if we should create a regression test for this bug.
    • [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  10. changed the title [-][HOLD for payment 2024-07-02] [$250] Track expense - "Join" button appears in report details page when tracking expense in self DM[/-] [+][HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Track expense - "Join" button appears in report details page when tracking expense in self DM[/+] on Jul 3, 2024
  11. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-10. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@c3024] The PR that introduced the bug has been identified. Link to the PR:
    • [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@c3024] Determine if we should create a regression test for this bug.
    • [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. c3024 commented on Jul 15, 2024

    @c3024
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@c3024] The PR that introduced the bug has been identified. Link to the PR: [Details Revamp] Update ReportDetailsPage for Rooms, Groups, Money Reports and Policy Expenses #43251
    • [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: bernhardoj@9c88ab8#r144232517
    • [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No, this could not have been identified earlier.
    • [@c3024] Determine if we should create a regression test for this bug. No, this was caught in staging. So, no separate test is required.
    • [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. NA
  14. twisterdotcom commented on Jul 15, 2024

    @twisterdotcom
    Contributor

    Hello folks, sorry I was OOO last week. I have a bunch to do, I will get them all done today. Thanks for your patience.

  15. twisterdotcom commented on Jul 17, 2024

    @twisterdotcom
    Contributor

    Payment Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions