Skip to content

[$250] Search - Not here page opens when returning from Hold page when accessing from header #44208

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.1-0
Reproducible in staging?: y
Reproducible in production?: no, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Launch New Expensify app.
  2. Go to any DM.
  3. Submit an expense to the user.
  4. Go to Search.
  5. Tap on the expense submitted in Step 3.
  6. Tap on the report header.
  7. Tap Hold.
  8. Tap Back button.

Expected Result:

App will return to previous page (report details page or transaction thread).

Actual Result:

App opens not here page.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6521492_1719060685913.RPReplay_Final1719060376.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01806bc01a7212eaae
  • Upwork Job ID: 1805263853657681677
  • Last Price Increase: 2024-06-24
Issue OwnerCurrent Issue Owner: @ikevin127

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 22, 2024
  2. melvin-bot commented on Jun 22, 2024

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 22, 2024

    @melvin-bot

    Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Jun 22, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Jun 22, 2024

    @m-natarajan
    Author

    @rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. 10 remaining items

  7. removed
    DeployBlockerIndicates it should block deploying the API
    on Jun 24, 2024
  8. rlinoz commented on Jun 24, 2024

    @rlinoz
    Contributor

    I think we should try to fix the underlying issue which is there is no backTo in the HoldReasonPage when coming from the Search page.

    cc: @bernhardoj

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 24, 2024
  10. changed the title [-]Search - Not here page opens when returning from Hold page when accessing from header[/-] [+][$250] Search - Not here page opens when returning from Hold page when accessing from header[/+] on Jun 24, 2024
  11. melvin-bot commented on Jun 24, 2024

    @melvin-bot
  12. melvin-bot commented on Jun 24, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

  13. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jun 25, 2024
  14. mountiny commented on Jun 25, 2024

    @mountiny
    Contributor

    Still looking for proposals, I think this is annoying UX issue but does not have to be blocker this late in the deployment cycle

  15. Kicu commented on Jun 25, 2024

    @Kicu
    Contributor

    I tried a few times with existing expense and with brand new expense but I could not reproduce this. I believe this probably is reproducible, but there has to be some extra circumstances to get this bug.

    my test

    rec-nav-bug.mov

    There is one thing that I have noticed: in the reproductions that do have this bug, for @rlinoz and @m-natarajan the animation when going from Details -> Hold looks like a "back" animation, suggestion this is a POP action. Whereas on my video I cleaarly get the PUSH and I'm moving forward. This definitely feels related to the bug, but thats the extent of what I found.

    Can someone give a 100% reliable way to reproduce this?

  16. rlinoz commented on Jun 25, 2024

    @rlinoz
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions