You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Search - Not here page opens when returning from Hold page when accessing from header #44208
Version Number: 9.0.1-0 Reproducible in staging?: y Reproducible in production?: no, new feature If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:
Action Performed:
Launch New Expensify app.
Go to any DM.
Submit an expense to the user.
Go to Search.
Tap on the expense submitted in Step 3.
Tap on the report header.
Tap Hold.
Tap Back button.
Expected Result:
App will return to previous page (report details page or transaction thread).
Actual Result:
App opens not here page.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Search - Not here page opens when returning from Hold page when accessing from header[/-][+][$250] Search - Not here page opens when returning from Hold page when accessing from header[/+]on Jun 24, 2024
I tried a few times with existing expense and with brand new expense but I could not reproduce this. I believe this probably is reproducible, but there has to be some extra circumstances to get this bug.
my test
rec-nav-bug.mov
There is one thing that I have noticed: in the reproductions that do have this bug, for @rlinoz and @m-natarajan the animation when going from Details -> Hold looks like a "back" animation, suggestion this is a POP action. Whereas on my video I cleaarly get the PUSH and I'm moving forward. This definitely feels related to the bug, but thats the extent of what I found.
Can someone give a 100% reliable way to reproduce this?
Activity
melvin-bot commentedon Jun 22, 2024
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 22, 2024
Triggered auto assignment to @rlinoz (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 22, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
m-natarajan commentedon Jun 22, 2024
@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
10 remaining items
rlinoz commentedon Jun 24, 2024
I think we should try to fix the underlying issue which is there is no
backToin the HoldReasonPage when coming from the Search page.cc: @bernhardoj
[-]Search - Not here page opens when returning from Hold page when accessing from header[/-][+][$250] Search - Not here page opens when returning from Hold page when accessing from header[/+]melvin-bot commentedon Jun 24, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01806bc01a7212eaae
melvin-bot commentedon Jun 24, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (
External)mountiny commentedon Jun 25, 2024
Still looking for proposals, I think this is annoying UX issue but does not have to be blocker this late in the deployment cycle
Kicu commentedon Jun 25, 2024
I tried a few times with existing expense and with brand new expense but I could not reproduce this. I believe this probably is reproducible, but there has to be some extra circumstances to get this bug.
my test
rec-nav-bug.mov
There is one thing that I have noticed: in the reproductions that do have this bug, for @rlinoz and @m-natarajan the animation when going from
Details->Holdlooks like a "back" animation, suggestion this is a POP action. Whereas on my video I cleaarly get the PUSH and I'm moving forward. This definitely feels related to the bug, but thats the extent of what I found.Can someone give a 100% reliable way to reproduce this?
rlinoz commentedon Jun 25, 2024
This was fixed in this other PR https://github.com/Expensify/App/pull/44359/files#diff-63967b77292f23428a8509ef11c77b0e68feb3a8ddddfa0fa560c38014915eb9R78-R80, not reproducible anymore.
So closing this one.