You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] iOS - Hold - Back button on transaction thread returns to Hold - Reason page after holding it #44423
issue found when validating #43618 Version Number: 9.0.2-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: applause internal team Slack conversation:
Action Performed:
Launch New Expensify app.
Go to workspace chat.
Submit an expense.
Go to transaction thread.
Tap 3-dot menu > Hold.
Enter reason > Save.
Tap on the back button.
Expected Result:
Back button on transaction thread will not return to Hold - Reason page.
Actual Result:
Back button on transaction thread returns to Hold - Reason page after holding the expense.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
backTo in this case is the transaction thread report. It should navigate back to the transaction thread because it exists on the stack, but the backTo route keeps being pushed to the nav stack because it's detected that the params of the backTo route is different with the params of the topmost central pane.
First, the actionParams?.screen === SCREENS.REPORT returns false. Second, the shallowCompare also returns false. That's because both actionParams?.screen and actionParams?.params are undefined. This happened after we simplify the root navigator.
Report screen was previously inside a CentralPaneNavigator, but it's not anymore now.
What changes do you think we should make in order to solve the problem?
Replace the usages of actionParams?.screen with action.payload.name and actionParams?.params with action.payload.params.
changed the title [-] iOS - Hold - Back button on transaction thread returns to Hold - Reason page after holding it[/-][+][HOLD for payment 2024-07-10] iOS - Hold - Back button on transaction thread returns to Hold - Reason page after holding it[/+]on Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
[@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@luacmartins] Determine if we should create a regression test for this bug.
[@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-07-10] iOS - Hold - Back button on transaction thread returns to Hold - Reason page after holding it[/-][+][HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] iOS - Hold - Back button on transaction thread returns to Hold - Reason page after holding it[/+]on Jul 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
[@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@luacmartins] Determine if we should create a regression test for this bug.
[@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jun 26, 2024
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 26, 2024
Triggered auto assignment to @hayata-suenaga (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 26, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
m-natarajan commentedon Jun 26, 2024
@hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
m-natarajan commentedon Jun 26, 2024
We think that this bug might be related to #wave-collect - Release 1
bernhardoj commentedon Jun 26, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Pressing back button after hold arrived at the hold reason page again.
What is the root cause of that problem?
After submitting the hold reason, we navigate to the backTo param.
App/src/pages/iou/HoldReasonPage.tsx
Lines 56 to 58 in 9862fdb
backTo in this case is the transaction thread report. It should navigate back to the transaction thread because it exists on the stack, but the backTo route keeps being pushed to the nav stack because it's detected that the params of the backTo route is different with the params of the topmost central pane.
App/src/libs/Navigation/linkTo/index.ts
Line 89 in 9862fdb
If the transaction thread report route is /r/123, then the backTo is also /r/123, but somehow the comparison fails.
App/src/libs/Navigation/linkTo/index.ts
Lines 80 to 86 in 9862fdb
App/src/libs/Navigation/linkTo/index.ts
Line 75 in 9862fdb
First, the
actionParams?.screen === SCREENS.REPORTreturns false. Second, the shallowCompare also returns false. That's because bothactionParams?.screenandactionParams?.paramsare undefined. This happened after we simplify the root navigator.Report screen was previously inside a CentralPaneNavigator, but it's not anymore now.
What changes do you think we should make in order to solve the problem?
Replace the usages of
actionParams?.screenwithaction.payload.nameandactionParams?.paramswithaction.payload.params.App/src/libs/Navigation/linkTo/index.ts
Lines 79 to 86 in 9862fdb
App/src/libs/Navigation/linkTo/index.ts
Lines 113 to 115 in 9862fdb
8 remaining items
luacmartins commentedon Jun 27, 2024
This was fixed by #44444 and CPed to staging. We're good to close since it was a regression.
[-] iOS - Hold - Back button on transaction thread returns to Hold - Reason page after holding it[/-][+][HOLD for payment 2024-07-10] iOS - Hold - Back button on transaction thread returns to Hold - Reason page after holding it[/+]melvin-bot commentedon Jul 3, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
melvin-bot commentedon Jul 3, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2024-07-10] iOS - Hold - Back button on transaction thread returns to Hold - Reason page after holding it[/-][+][HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] iOS - Hold - Back button on transaction thread returns to Hold - Reason page after holding it[/+]melvin-bot commentedon Jul 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-24. 🎊
melvin-bot commentedon Jul 17, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: