Skip to content

[HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] [$250] [Search v1] - Workspace switcher on Search is not synchronized with workspace switcher in Inbox #44433

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • Account has at least one workspace.
  1. Go to staging.new.expensify.com
  2. Open workspace switcher.
  3. Select any workspace other than Expensify.
  4. Go to Search.
  5. Open the workspace switcher on Search.

Expected Result:

The workspace switcher on Search should be synchronized with that on Inbox.

Actual Result:

The workspace switcher on Search shows "Expensify", but when opened, it shows the same selected workspace in Inbox.

Also, on Search page, the breadcrumbs always reset to Expensify when selecting a different Search category.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6524650_1719357586479.20240626_071616.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01555554fcd588e68c
  • Upwork Job ID: 1805912913347680498
  • Last Price Increase: 2024-06-26
  • Automatic offers:
    • hoangzinh | Reviewer | 102886879
    • allgandalf | Contributor | 102905430
Issue OwnerCurrent Issue Owner: @anmurali

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 26, 2024
  2. melvin-bot commented on Jun 26, 2024

    @melvin-bot

    Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jun 26, 2024

    @melvin-bot

    Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Jun 26, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Jun 26, 2024

    @izarutskaya
    Author

    @anmurali I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Jun 26, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #vip-vsb

  7. nyomanjyotisa commented on Jun 26, 2024

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspace switcher on Search is not synchronized with workspace switcher in Inbox

    What is the root cause of that problem?

    We pass policyIDs to the activeWorkspaceID, and in this case policyIDs is undefined

    activeWorkspaceID={policyIDs}

    What changes do you think we should make in order to solve the problem?

    <TopBar
    activeWorkspaceID={policyIDs}
    breadcrumbLabel={translate('common.search')}
    shouldDisplaySearch={false}
    />

    Change the code above to use activeWorkspaceID from useActiveWorkspaceFromNavigationState() if policyIDs is undefined

                   <TopBar
                        activeWorkspaceID={policyIDs ?? activeWorkspaceID}
                        breadcrumbLabel={translate('common.search')}
                        shouldDisplaySearch={false}
                    />
    

    Also need to update other parts accordingly

    What alternative solutions did you explore? (Optional)

    Change the policyIDs with activeWorkspaceID from useActiveWorkspaceFromNavigationState()

                   <TopBar
                        activeWorkspaceID={activeWorkspaceID}
                        breadcrumbLabel={translate('common.search')}
                        shouldDisplaySearch={false}
                    />
    
  8. 37 remaining items

  9. luacmartins commented on Jul 10, 2024

    @luacmartins
    Contributor

    We can complete the items in the checklist, but we can skip the test steps, since we'll add those as part of the project wrap up.

  10. luacmartins commented on Jul 12, 2024

    @luacmartins
    Contributor

    Just missing payment here

  11. allgandalf commented on Jul 15, 2024

    @allgandalf
    Contributor

    Waiting for the Payment....

  12. grgia commented on Jul 15, 2024

    @grgia
    Contributor

    @anmurali bump on payment

  13. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    @anmurali, @luacmartins, @grgia, @WojtekBoman, @allgandalf Eep! 4 days overdue now. Issues have feelings too...

  14. anmurali commented on Jul 16, 2024

    @anmurali

    Paid.

  15. changed the title [-][HOLD for payment 2024-07-10] [$250] [Search v1] - Workspace switcher on Search is not synchronized with workspace switcher in Inbox[/-] [+][HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] [$250] [Search v1] - Workspace switcher on Search is not synchronized with workspace switcher in Inbox[/+] on Jul 17, 2024
  16. melvin-bot commented on Jul 17, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-24. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Jul 17, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@allgandalf] The PR that introduced the bug has been identified. Link to the PR:
    • [@allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@allgandalf] Determine if we should create a regression test for this bug.
    • [@allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions