You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] [$250] [Search v1] - Workspace switcher on Search is not synchronized with workspace switcher in Inbox #44433
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@anmurali I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
changed the title [-][HOLD for payment 2024-07-10] [$250] [Search v1] - Workspace switcher on Search is not synchronized with workspace switcher in Inbox[/-][+][HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] [$250] [Search v1] - Workspace switcher on Search is not synchronized with workspace switcher in Inbox[/+]on Jul 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@allgandalf] The PR that introduced the bug has been identified. Link to the PR:
[@allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allgandalf] Determine if we should create a regression test for this bug.
[@allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jun 26, 2024
Triggered auto assignment to @grgia (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 26, 2024
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jun 26, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Jun 26, 2024
@anmurali I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Jun 26, 2024
We think this issue might be related to the #vip-vsb
nyomanjyotisa commentedon Jun 26, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace switcher on Search is not synchronized with workspace switcher in Inbox
What is the root cause of that problem?
We pass
policyIDsto theactiveWorkspaceID, and in this case policyIDs is undefinedApp/src/pages/Search/SearchPageBottomTab.tsx
Line 63 in 0c20881
What changes do you think we should make in order to solve the problem?
App/src/pages/Search/SearchPageBottomTab.tsx
Lines 62 to 66 in 0c20881
Change the code above to use activeWorkspaceID from useActiveWorkspaceFromNavigationState() if policyIDs is undefined
Also need to update other parts accordingly
What alternative solutions did you explore? (Optional)
Change the policyIDs with activeWorkspaceID from useActiveWorkspaceFromNavigationState()
37 remaining items
luacmartins commentedon Jul 10, 2024
We can complete the items in the checklist, but we can skip the test steps, since we'll add those as part of the project wrap up.
luacmartins commentedon Jul 12, 2024
Just missing payment here
allgandalf commentedon Jul 15, 2024
Waiting for the Payment....
grgia commentedon Jul 15, 2024
@anmurali bump on payment
melvin-bot commentedon Jul 15, 2024
@anmurali, @luacmartins, @grgia, @WojtekBoman, @allgandalf Eep! 4 days overdue now. Issues have feelings too...
anmurali commentedon Jul 16, 2024
Paid.
[-][HOLD for payment 2024-07-10] [$250] [Search v1] - Workspace switcher on Search is not synchronized with workspace switcher in Inbox[/-][+][HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] [$250] [Search v1] - Workspace switcher on Search is not synchronized with workspace switcher in Inbox[/+]melvin-bot commentedon Jul 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-24. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 17, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: