Skip to content

[HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] Send invoice - Hold option appears for invoice and error shows up when attempting to hold it #44450

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Send invoice
  3. Enter amount > Next
  4. Send invoice to any user
  5. Go to invoice thread
  6. Click 3-dot menu
  7. Click Hold
  8. Enter a reason and save it

Expected Result:

Hold option should not appear for invoice if it is not supported (production behavior)

Actual Result:

Hold option appears for invoice and error shows up when attempting to hold the invoice

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6525058_1719394493471.20240626_173231.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 26, 2024
  2. melvin-bot commented on Jun 26, 2024

    @melvin-bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jun 26, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jun 26, 2024

    @lanitochka17
    Author

    @carlosmiceli FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. etCoderDysto commented on Jun 26, 2024

    @etCoderDysto
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Hold option appears for invoice and error shows up when attempting to hold it

    What is the root cause of that problem?

    We are not checking if the report is an invoice report before adding the hold menu item to threeDotsMenuItems here

    if (!isOnHold && (isRequestIOU || canModifyStatus) && !isScanning) {
    threeDotsMenuItems.push({
    icon: Expensicons.Stopwatch,
    text: translate('iou.hold'),
    onSelected: () => changeMoneyRequestStatus(),
    });

    What changes do you think we should make in order to solve the problem?

    Check if the report is invoice here by adding the following code

    const isInvoiceReport = ReportUtils.isInvoiceReport(moneyRequestReport);

    Add && !isInvoiceReport to the condition below to prevent adding hold menu item to threeDotsMenuItems if the report is an invoice report

    if (!isOnHold && (isRequestIOU || canModifyStatus) && !isScanning && !isInvoiceReport)

    if (!isOnHold && (isRequestIOU || canModifyStatus) && !isScanning) {

    What alternative solutions did you explore? (Optional)

  6. carlosmiceli commented on Jun 26, 2024

    @carlosmiceli
    Contributor

    @etCoderDysto that looks promising, let's do it!

  7. etCoderDysto commented on Jun 26, 2024

    @etCoderDysto
    Contributor

    Great! I am raising ASAP.

  8. removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 26, 2024
  9. 27 remaining items

  10. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-10. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  13. abekkala commented on Jul 8, 2024

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR JUL 10

    @etCoderDysto I'm having a hard time finding your profile in Upwork. Can you link it here and I can send your offer!
    Thanks

  14. abekkala commented on Jul 8, 2024

    @abekkala
    Contributor

    updated summary above with your offer

  15. etCoderDysto commented on Jul 8, 2024

    @etCoderDysto
    Contributor

    I have accepted the offer. Thank you!

  16. etCoderDysto commented on Jul 9, 2024

    @etCoderDysto
    Contributor

    Since we are removing three-dot menu in recent releases, I don't think we need to create a regression test step.

  17. abekkala commented on Jul 10, 2024

    @abekkala
    Contributor

    @etCoderDysto payment sent and contract ended - thank you! 🎉

  18. changed the title [-][HOLD for payment 2024-07-10] Send invoice - Hold option appears for invoice and error shows up when attempting to hold it[/-] [+][HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] Send invoice - Hold option appears for invoice and error shows up when attempting to hold it[/+] on Jul 17, 2024
  19. melvin-bot commented on Jul 17, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-24. 🎊

    For reference, here are some details about the assignees on this issue:

  20. melvin-bot commented on Jul 17, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions