You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] Send invoice - Hold option appears for invoice and error shows up when attempting to hold it #44450
Version Number: 9.0.2-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to FAB > Send invoice
Enter amount > Next
Send invoice to any user
Go to invoice thread
Click 3-dot menu
Click Hold
Enter a reason and save it
Expected Result:
Hold option should not appear for invoice if it is not supported (production behavior)
Actual Result:
Hold option appears for invoice and error shows up when attempting to hold the invoice
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@carlosmiceli FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@carlosmiceli] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. (No discussion)
[@etCoderDysto] Determine if we should create a regression test for this bug.
[@etCoderDysto] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-07-10] Send invoice - Hold option appears for invoice and error shows up when attempting to hold it[/-][+][HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] Send invoice - Hold option appears for invoice and error shows up when attempting to hold it[/+]on Jul 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@carlosmiceli] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. (No discussion)
[@etCoderDysto] Determine if we should create a regression test for this bug.
[@etCoderDysto] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jun 26, 2024
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 26, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jun 26, 2024
@carlosmiceli FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
etCoderDysto commentedon Jun 26, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Hold option appears for invoice and error shows up when attempting to hold it
What is the root cause of that problem?
We are not checking if the report is an invoice report before adding the
holdmenu item tothreeDotsMenuItemshereApp/src/components/MoneyReportHeader.tsx
Lines 258 to 263 in 0c20881
What changes do you think we should make in order to solve the problem?
Check if the report is invoice here by adding the following code
Add
&& !isInvoiceReportto the condition below to prevent addingholdmenu item tothreeDotsMenuItemsif the report is an invoice reportApp/src/components/MoneyReportHeader.tsx
Line 258 in 0c20881
What alternative solutions did you explore? (Optional)
carlosmiceli commentedon Jun 26, 2024
@etCoderDysto that looks promising, let's do it!
etCoderDysto commentedon Jun 26, 2024
Great! I am raising ASAP.
27 remaining items
melvin-bot commentedon Jul 3, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 3, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
abekkala commentedon Jul 8, 2024
PAYMENT SUMMARY FOR JUL 10
@etCoderDysto I'm having a hard time finding your profile in Upwork. Can you link it here and I can send your offer!
Thanks
abekkala commentedon Jul 8, 2024
updated summary above with your offer
etCoderDysto commentedon Jul 8, 2024
I have accepted the offer. Thank you!
etCoderDysto commentedon Jul 9, 2024
Since we are removing three-dot menu in recent releases, I don't think we need to create a regression test step.
abekkala commentedon Jul 10, 2024
@etCoderDysto payment sent and contract ended - thank you! 🎉
[-][HOLD for payment 2024-07-10] Send invoice - Hold option appears for invoice and error shows up when attempting to hold it[/-][+][HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] Send invoice - Hold option appears for invoice and error shows up when attempting to hold it[/+]melvin-bot commentedon Jul 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-24. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 17, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: