You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-10] Expense - "Hold" banner appears on top briefly after deleting the expense #44454
Version Number: 9.0.2-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/4671017 Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to FAB > Start chat > Manual.
Submit a manual expense to any user that has no unsettled expense (important)
Go to transaction thread
Click 3-dot menu > Delete expense
Delete the expense
Note that the "Hold" banner appears on top briefly
Expected Result:
"Hold" banner will not show up when deleting the expense
Actual Result:
"Hold" banner appears on top briefly after deleting the expense
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-] Expense - "Hold" banner appears on top briefly after deleting the expense[/-][+][HOLD for payment 2024-07-10] Expense - "Hold" banner appears on top briefly after deleting the expense[/+]on Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
melvin-bot commentedon Jun 26, 2024
Triggered auto assignment to @rlinoz (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 26, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jun 26, 2024
@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
rlinoz commentedon Jun 26, 2024
No need to block on this.
rlinoz commentedon Jun 26, 2024
The problem is here https://github.com/Expensify/App/pull/43618/files#diff-577fcc5f3a5e4930916ff310e61c38edfa093792fe3ab55b9a30d2aecd8811dbR6557, when there is no reportTransactions we will compute as having expenses on hold
[-] Expense - "Hold" banner appears on top briefly after deleting the expense[/-][+][HOLD for payment 2024-07-10] Expense - "Hold" banner appears on top briefly after deleting the expense[/+]melvin-bot commentedon Jul 3, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
rlinoz commentedon Jul 3, 2024
No payment due, closing.