Skip to content

[HOLD for payment 2024-07-24] [$250] Submit expense - "Hold" option is not present in report details page #44470

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): abebemiherat@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to a workspace chat with no prior expense submissions and click the plus sign
  2. Submit an expense by adding the amount, merchant, and confirming it
  3. Go to IOU, click the headers, and notice that the 'Hold' option is not available

Expected Result:

The "Hold" option should be present on the report details page

Actual Result:

After submitting a single expense in the workspace chat, the 'Hold' option appears in IOU when clicking the three dots. However, the "Hold" option is not present on the report details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6525289_1719412383105.Screen_Recording_2024-06-26_at_5.13.22_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0166273ab3240af3ae
  • Upwork Job ID: 1806101011812532362
  • Last Price Increase: 2024-07-03
  • Automatic offers:
    • brunovjk | Contributor | 102893192
    • nkdengineer | Contributor | 102991523
Issue OwnerCurrent Issue Owner: @sakluger

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 26, 2024
  2. melvin-bot commented on Jun 26, 2024

    @melvin-bot

    Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jun 26, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jun 26, 2024

    @lanitochka17
    Author

    @aldo-expensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. nyomanjyotisa commented on Jun 26, 2024

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    "Hold" option is not present in report details page

    What is the root cause of that problem?

    function canHoldUnholdReportAction(reportAction: OnyxInputOrEntry<ReportAction>): {canHoldRequest: boolean; canUnholdRequest: boolean} {

    On this code, if the current action is not MoneyRequestAction, it directly return return {canHoldRequest: false, canUnholdRequest: false};

    But in this case, the current actionName is "REPORTPREVIEW", its childReportName is "IOU", and childMoneyRequestCount is 1

    It need to show "Hold" in this case

    What changes do you think we should make in order to solve the problem?

    https://github.com/Expensify/App/blob/eb83809486784265a4aba70a9ed0436dd3f29bbe/src/libs/ReportUtils.ts#L2749C10-L2760
    update this canHoldUnholdReportAction function to not return return {canHoldRequest: false, canUnholdRequest: false}; if actionName is "REPORTPREVIEW", childReportName is "IOU", childMoneyRequestCount is 1. Then ensure it return either canHoldRequest/canUnholdRequest : true in this case

    What alternative solutions did you explore? (Optional)

  6. 74 remaining items

  7. changed the title [-][$250] Submit expense - "Hold" option is not present in report details page[/-] [+][HOLD for payment 2024-07-24] [$250] Submit expense - "Hold" option is not present in report details page[/+] on Jul 17, 2024
  8. melvin-bot commented on Jul 17, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Jul 17, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-24. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Jul 17, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@brunovjk] The PR that introduced the bug has been identified. Link to the PR:
    • [@brunovjk] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@brunovjk] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@brunovjk] Determine if we should create a regression test for this bug.
    • [@brunovjk] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. brunovjk commented on Jul 22, 2024

    @brunovjk
    Contributor
    • [@brunovjk] The PR that introduced the bug has been identified. Link to the PR: N/A
    • [@brunovjk] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • [@brunovjk] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • [@brunovjk] Determine if we should create a regression test for this bug. Yes
    • [@brunovjk] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Navigate to a workspace chat with no prior expense submissions.
    2. Click the plus sign to submit an expense, adding the amount and merchant, and confirm.
    3. Go to IOU, click the headers, and observe the options.
    4. Click on the report preview to open the combined report.
    5. Click on the header to open the report detail page.
    6. Verify that the "Hold" option is present on the report details page.

    Do we agree 👍 or 👎

  12. sakluger commented on Jul 23, 2024

    @sakluger
    Contributor

    @brunovjk you don't think that we should add a regression test for this one?

  13. brunovjk commented on Jul 23, 2024

    @brunovjk
    Contributor

    @sakluger I thought no, but what do you think?

    What do you think of these tests @sakluger?

    @nkdengineer @marcochavezf

  14. sakluger commented on Jul 24, 2024

    @sakluger
    Contributor

    Yeah, I think we want to include this in our regression tests. Those steps look good!

  15. sakluger commented on Jul 24, 2024

    @sakluger
    Contributor

    Summarizing payment on this issue:

    Contributor: @nkdengineer $250, paid via Upwork
    Contributor+: @brunovjk $250, paid via Upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions