You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-24] [$250] Submit expense - "Hold" option is not present in report details page #44470
Version Number: 9.0.2-0 Reproducible in staging?: Y Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):abebemiherat@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Go to a workspace chat with no prior expense submissions and click the plus sign
Submit an expense by adding the amount, merchant, and confirming it
Go to IOU, click the headers, and notice that the 'Hold' option is not available
Expected Result:
The "Hold" option should be present on the report details page
Actual Result:
After submitting a single expense in the workspace chat, the 'Hold' option appears in IOU when clicking the three dots. However, the "Hold" option is not present on the report details page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@aldo-expensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-][$250] Submit expense - "Hold" option is not present in report details page[/-][+][HOLD for payment 2024-07-24] [$250] Submit expense - "Hold" option is not present in report details page[/+]on Jul 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@brunovjk] The PR that introduced the bug has been identified. Link to the PR:
[@brunovjk] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@brunovjk] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@brunovjk] Determine if we should create a regression test for this bug.
[@brunovjk] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@brunovjk] The PR that introduced the bug has been identified. Link to the PR: N/A
[@brunovjk] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@brunovjk] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@brunovjk] Determine if we should create a regression test for this bug. Yes
[@brunovjk] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Navigate to a workspace chat with no prior expense submissions.
Click the plus sign to submit an expense, adding the amount and merchant, and confirm.
Go to IOU, click the headers, and observe the options.
Click on the report preview to open the combined report.
Click on the header to open the report detail page.
Verify that the "Hold" option is present on the report details page.
Activity
melvin-bot commentedon Jun 26, 2024
Triggered auto assignment to @aldo-expensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 26, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jun 26, 2024
@aldo-expensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
nyomanjyotisa commentedon Jun 26, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Hold" option is not present in report details page
What is the root cause of that problem?
App/src/libs/ReportUtils.ts
Line 2749 in eb83809
On this code, if the current action is not MoneyRequestAction, it directly return
return {canHoldRequest: false, canUnholdRequest: false};But in this case, the current actionName is "REPORTPREVIEW", its childReportName is "IOU", and childMoneyRequestCount is 1
It need to show "Hold" in this case
What changes do you think we should make in order to solve the problem?
https://github.com/Expensify/App/blob/eb83809486784265a4aba70a9ed0436dd3f29bbe/src/libs/ReportUtils.ts#L2749C10-L2760
update this
canHoldUnholdReportActionfunction to not returnreturn {canHoldRequest: false, canUnholdRequest: false};if actionName is "REPORTPREVIEW", childReportName is "IOU", childMoneyRequestCount is 1. Then ensure it return either canHoldRequest/canUnholdRequest : true in this caseWhat alternative solutions did you explore? (Optional)
74 remaining items
[-][$250] Submit expense - "Hold" option is not present in report details page[/-][+][HOLD for payment 2024-07-24] [$250] Submit expense - "Hold" option is not present in report details page[/+]melvin-bot commentedon Jul 17, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-24. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 17, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
brunovjk commentedon Jul 22, 2024
Regression Test Proposal
Do we agree 👍 or 👎
sakluger commentedon Jul 23, 2024
@brunovjk you don't think that we should add a regression test for this one?
brunovjk commentedon Jul 23, 2024
@sakluger I thought no, but what do you think?What do you think of these tests @sakluger?
@nkdengineer @marcochavezf
sakluger commentedon Jul 24, 2024
Yeah, I think we want to include this in our regression tests. Those steps look good!
sakluger commentedon Jul 24, 2024
Summarizing payment on this issue:
Contributor: @nkdengineer $250, paid via Upwork
Contributor+: @brunovjk $250, paid via Upwork