Skip to content

Lint is failing on main #44494

Closed
Closed

Description

@roryabraham

Problem

Lint is failing with a timeout on main, just like in this CI job. This will seize up a lot of our development in E/App because we heavily rely on lint to prevent bugs and promote code quality.

Solution

Investigate and fix the issue with our lint configuration.

Issue OwnerCurrent Issue Owner: @dukenv0307

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 26, 2024
  2. self-assigned this
    on Jun 26, 2024
  3. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 26, 2024
  4. melvin-bot commented on Jun 26, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

  5. melvin-bot commented on Jun 26, 2024

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. roryabraham commented on Jun 26, 2024

    @roryabraham
    ContributorAuthor

    this comment is very interesting

  7. roryabraham commented on Jun 26, 2024

    @roryabraham
    ContributorAuthor

    This is fixed now by simply increasing the memory given to eslint. I did try applying the diff from that comment to run lint in parallel, but actually with a cache and more memory, it was faster to run eslint in one process than in many. So I'm calling this done for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions