You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-17] [$250] Report fields - Row is not grayed out when added/edited offline #44798
Version Number: 9.0.4.0 Reproducible in staging?: y Reproducible in production?: no new feature If this was caught during regression testing, add the test name, ID and link from TestRail: n/a Email or phone of affected tester (no customers): n/a Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:
Action Performed:
Go to staging.new.expensify.com
Go to Workspace settings > Report fields (enable from More features)
Go offline.
Tap Add field.
Add any report field and save it.
Expected Result:
The row will be grayed out when added offline.
Actual Result:
The row is not grayed out when added offline. This also applies to List values editor for List report field.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@techievivek FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Report fields - Row is not grayed out when added/edited offline[/-][+][HOLD for payment 2024-07-17] [$250] Report fields - Row is not grayed out when added/edited offline[/+]on Jul 19, 2024
Activity
melvin-bot commentedon Jul 4, 2024
Triggered auto assignment to @techievivek (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 4, 2024
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jul 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
m-natarajan commentedon Jul 4, 2024
@techievivek FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
m-natarajan commentedon Jul 4, 2024
We think that this bug might be related to #vip-vsb
nkdengineer commentedon Jul 4, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The row is not grayed out when added offline. This also applies to List values editor for List report field.
What is the root cause of that problem?
We don't add the
pendingActionfield when we get the list report fields hereApp/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx
Line 67 in 83eb7e6
What changes do you think we should make in order to solve the problem?
We should add
pendingActionhere when we get the list report field to apply the gray out style when this report field is added/edited offline.App/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx
Line 67 in 83eb7e6
App/src/libs/actions/Policy/ReportFields.ts
Lines 162 to 164 in 83eb7e6
What alternative solutions did you explore? (Optional)
50 remaining items
[-][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Report fields - Row is not grayed out when added/edited offline[/-][+][HOLD for payment 2024-07-17] [$250] Report fields - Row is not grayed out when added/edited offline[/+]zanyrenney commentedon Jul 19, 2024
bump @shubham1206agra can you review the comment above as this is being raised as a deploy blocker?
shubham1206agra commentedon Jul 19, 2024
@zanyrenney Already addressed here #45461 (comment)
zanyrenney commentedon Jul 19, 2024
Ah great, thank you!
zanyrenney commentedon Jul 19, 2024
I'll move ahead with the payments in this case 🙇🏼
zanyrenney commentedon Jul 19, 2024
have asked @etCoderDysto to apply to job for payout
shubham1206agra commentedon Jul 19, 2024
Payments will be handled later at one place for this.
zanyrenney commentedon Jul 19, 2024
Ah okay that's not what the payment summary says:

But happy to go with that then. I will close this one out!
etCoderDysto commentedon Jul 19, 2024
@zanyrenney Only mollfpr is paid. I am not paid yet.
And here is the payment summary
zanyrenney commentedon Jul 19, 2024
Cool, payment summary:
@mollfpr requires payment through NewDot Manual Requests - paid via ND
@etCoderDysto requires payment (Needs manual offer from BZ) - paid $50 via UPwork.