Skip to content

[HOLD for payment 2024-07-17] [$250] Report fields - Row is not grayed out when added/edited offline #44798

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.4.0
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers): n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Workspace settings > Report fields (enable from More features)
  3. Go offline.
  4. Tap Add field.
  5. Add any report field and save it.

Expected Result:

The row will be grayed out when added offline.

Actual Result:

The row is not grayed out when added offline. This also applies to List values editor for List report field.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6532504_1720042394848.report_fi_ofline.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018389cb0ae25e3928
  • Upwork Job ID: 1808737930014144742
  • Last Price Increase: 2024-07-04
Issue OwnerCurrent Issue Owner: @zanyrenney

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 4, 2024
  2. melvin-bot commented on Jul 4, 2024

    @melvin-bot

    Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jul 4, 2024

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Jul 4, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Jul 4, 2024

    @m-natarajan
    Author

    @techievivek FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. m-natarajan commented on Jul 4, 2024

    @m-natarajan
    Author

    We think that this bug might be related to #vip-vsb

  7. nkdengineer commented on Jul 4, 2024

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The row is not grayed out when added offline. This also applies to List values editor for List report field.

    What is the root cause of that problem?

    We don't add the pendingAction field when we get the list report fields here

    return Object.values(filteredPolicyFieldList).map((reportField) => ({

    What changes do you think we should make in order to solve the problem?

    We should add pendingAction here when we get the list report field to apply the gray out style when this report field is added/edited offline.

    return Object.values(filteredPolicyFieldList).map((reportField) => ({

    pendingFields: {
    [fieldKey]: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
    },

    What alternative solutions did you explore? (Optional)

  8. 50 remaining items

  9. changed the title [-][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Report fields - Row is not grayed out when added/edited offline[/-] [+][HOLD for payment 2024-07-17] [$250] Report fields - Row is not grayed out when added/edited offline[/+] on Jul 19, 2024
  10. zanyrenney commented on Jul 19, 2024

    @zanyrenney
    Contributor

    bump @shubham1206agra can you review the comment above as this is being raised as a deploy blocker?

  11. shubham1206agra commented on Jul 19, 2024

    @shubham1206agra
    Contributor

    @zanyrenney Already addressed here #45461 (comment)

  12. zanyrenney commented on Jul 19, 2024

    @zanyrenney
    Contributor

    Ah great, thank you!

  13. zanyrenney commented on Jul 19, 2024

    @zanyrenney
    Contributor

    I'll move ahead with the payments in this case 🙇🏼

  14. zanyrenney commented on Jul 19, 2024

    @zanyrenney
    Contributor

    have asked @etCoderDysto to apply to job for payout

  15. shubham1206agra commented on Jul 19, 2024

    @shubham1206agra
    Contributor

    Payments will be handled later at one place for this.

  16. zanyrenney commented on Jul 19, 2024

    @zanyrenney
    Contributor

    Ah okay that's not what the payment summary says:
    2024-07-19_14-52-55

    But happy to go with that then. I will close this one out!

  17. etCoderDysto commented on Jul 19, 2024

    @etCoderDysto
    Contributor
  18. zanyrenney commented on Jul 19, 2024

    @zanyrenney
    Contributor

    Cool, payment summary:
    @mollfpr requires payment through NewDot Manual Requests - paid via ND
    @etCoderDysto requires payment (Needs manual offer from BZ) - paid $50 via UPwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions