Skip to content

[HOLD for payment 2024-07-24] [$250] Login – Expensify changes to Hidden in LHN if login with new Gmail account and reload page #44833

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.4-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4694015
Email or phone of affected tester (no customers): ponikarchuks+24724@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in with a new Gmail account
  3. Choose Track and Budget Expenses
  4. Enter your name in Onboarding modal
  5. Verify Expensify and Concierge chats present in LHN
  6. Reload page

Expected Result:

Expensify and Concierge chats present in LHN

Actual Result:

Hidden is name of Expensify and user name/Hidden as a Concierge in LHN, when login with new Gmail account and reload page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6532713_1720069292265.Hidden_is_name_of_Expensify_and_user_name_as_a_Concierge.mp4
2024-07-08_13-03-19.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ac469d1b3213174d
  • Upwork Job ID: 1810389985506651244
  • Last Price Increase: 2024-07-08
  • Automatic offers:
    • ahmedGaber93 | Reviewer | 103078265
    • dominictb | Contributor | 103078266
Issue OwnerCurrent Issue Owner: @Christinadobrzyn

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 4, 2024
  2. melvin-bot commented on Jul 4, 2024

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. dominictb commented on Jul 4, 2024

    @dominictb
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Hidden is name of Expensify and user name/Hidden as a Concierge in LHN, when login with new Gmail account and reload page

    What is the root cause of that problem?

    In

    if (report?.participantAccountIDs) {

    we just check report?.participantAccountIDs, to start migrating Participants.

    After login, participantAccountIDs is empty ([]) so there's nothing to migrate. but it still pass the above check

    -> the valid accountID in participants is set to null

    participants[accountID] = null;

    Logic to display Hidden based on participants

    We're showing the display name based on option.text in

    const fullTitle = isGroupChat ? ReportUtils.getGroupChatName(undefined, false, report) : optionItem.text;

    option.text = ReportUtils.getReportName

    const reportName = ReportUtils.getReportName(report, policy);
    result.text = reportName;

    In the detail implementation of getReportName, we get the reportName from participantsWithoutCurrentUser

    return participantsWithoutCurrentUser.map((accountID) => getDisplayNameForParticipant(accountID, isMultipleParticipantReport)).join(', ');

    In this case participantsWithoutCurrentUser is empty -> Hidden is shown

    const title = fullTitle || translate('common.hidden');

    What changes do you think we should make in order to solve the problem?

    We need to add the check for empty list in here

                if (report?.participantAccountIDs && !isEmpty(report?.participantAccountIDs)) {
    

    What alternative solutions did you explore? (Optional)

    NA

  4. Christinadobrzyn commented on Jul 8, 2024

    @Christinadobrzyn
    Contributor

    I'm not sure if this can be external - we'll start there.

  5. changed the title [-]Login – Expensify changes to Hidden in LHN if login with new Gmail account and reload page[/-] [+][$250] Login – Expensify changes to Hidden in LHN if login with new Gmail account and reload page[/+] on Jul 8, 2024
  6. melvin-bot commented on Jul 8, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 8, 2024
  8. melvin-bot commented on Jul 8, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

  9. 16 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 17, 2024
  11. changed the title [-][$250] Login – Expensify changes to Hidden in LHN if login with new Gmail account and reload page[/-] [+][HOLD for payment 2024-07-24] [$250] Login – Expensify changes to Hidden in LHN if login with new Gmail account and reload page[/+] on Jul 17, 2024
  12. melvin-bot commented on Jul 17, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jul 17, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-24. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Jul 17, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR:
    • [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ahmedGaber93] Determine if we should create a regression test for this bug.
    • [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/414726
  15. ahmedGaber93 commented on Jul 22, 2024

    @ahmedGaber93
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Regression Test Proposal

    1. Go to NewDot
    2. Log in with a new Gmail account
    3. Choose Track and Budget Expenses
    4. Enter your name in Onboarding modal
    5. Verify Expensify and Concierge chats present in LHN
    6. Reload page
    7. Verify that: Expensify and Concierge chats present in LHN with correct name instead of Hidden

    Do we agree 👍 or 👎

  16. Christinadobrzyn commented on Jul 23, 2024

    @Christinadobrzyn
    Contributor
  17. Christinadobrzyn commented on Jul 24, 2024

    @Christinadobrzyn
    Contributor

    Payment day - payment summary here - #44833 (comment)

    Closing this as complete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions