You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-24] [$250] Login – Expensify changes to Hidden in LHN if login with new Gmail account and reload page #44833
changed the title [-]Login – Expensify changes to Hidden in LHN if login with new Gmail account and reload page[/-][+][$250] Login – Expensify changes to Hidden in LHN if login with new Gmail account and reload page[/+]on Jul 8, 2024
changed the title [-][$250] Login – Expensify changes to Hidden in LHN if login with new Gmail account and reload page[/-][+][HOLD for payment 2024-07-24] [$250] Login – Expensify changes to Hidden in LHN if login with new Gmail account and reload page[/+]on Jul 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR:
[@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ahmedGaber93] Determine if we should create a regression test for this bug.
[@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@ahmedGaber93] Determine if we should create a regression test for this bug. Yes
[@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Go to NewDot
Log in with a new Gmail account
Choose Track and Budget Expenses
Enter your name in Onboarding modal
Verify Expensify and Concierge chats present in LHN
Reload page
Verify that: Expensify and Concierge chats present in LHN with correct name instead of Hidden
Activity
melvin-bot commentedon Jul 4, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.dominictb commentedon Jul 4, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Hidden is name of Expensify and user name/Hidden as a Concierge in LHN, when login with new Gmail account and reload page
What is the root cause of that problem?
In
App/src/libs/migrations/Participants.ts
Line 46 in 6ac95e4
we just check
report?.participantAccountIDs, to start migrating Participants.After login,
participantAccountIDsis empty ([]) so there's nothing to migrate. but it still pass the above check-> the valid accountID in
participantsis set to nullApp/src/libs/migrations/Participants.ts
Line 65 in 6ac95e4
Logic to display Hidden based on participants
We're showing the display name based on
option.textinApp/src/components/LHNOptionsList/OptionRowLHN.tsx
Line 134 in a91b7f8
option.text = ReportUtils.getReportName
App/src/libs/SidebarUtils.ts
Lines 442 to 444 in a91b7f8
In the detail implementation of getReportName, we get the reportName from
participantsWithoutCurrentUserApp/src/libs/ReportUtils.ts
Line 3466 in a91b7f8
In this case
participantsWithoutCurrentUseris empty -> Hidden is shownApp/src/components/DisplayNames/index.tsx
Line 9 in a91b7f8
What changes do you think we should make in order to solve the problem?
We need to add the check for empty list in here
What alternative solutions did you explore? (Optional)
NA
Christinadobrzyn commentedon Jul 8, 2024
I'm not sure if this can be external - we'll start there.
[-]Login – Expensify changes to Hidden in LHN if login with new Gmail account and reload page[/-][+][$250] Login – Expensify changes to Hidden in LHN if login with new Gmail account and reload page[/+]melvin-bot commentedon Jul 8, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01ac469d1b3213174d
melvin-bot commentedon Jul 8, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (
External)16 remaining items
[-][$250] Login – Expensify changes to Hidden in LHN if login with new Gmail account and reload page[/-][+][HOLD for payment 2024-07-24] [$250] Login – Expensify changes to Hidden in LHN if login with new Gmail account and reload page[/+]melvin-bot commentedon Jul 17, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-24. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 17, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
ahmedGaber93 commentedon Jul 22, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression Test Proposal
Do we agree 👍 or 👎
Christinadobrzyn commentedon Jul 23, 2024
Regression test - https://github.com/Expensify/Expensify/issues/414726
Payouts due on payment day:
Christinadobrzyn commentedon Jul 24, 2024
Payment day - payment summary here - #44833 (comment)
Closing this as complete!