You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-07] [$250] Login – Please enter an email or phone number is not is not displayed in Spanish #44849
Version Number: 9.0.4.0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):gocemate+a523@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Scroll down the login page
Change the language to Spanish
Expected Result:
"Please enter an email or phone number" error message should be displayed in Spanish
Actual Result:
"Please enter an email or phone number" error message is not displayed in Spanish
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Login – Please enter an email or phone number is not is not displayed in Spanish[/-][+][$250] Login – Please enter an email or phone number is not is not displayed in Spanish[/+]on Jul 8, 2024
Activity
ShridharGoel commentedon Jul 4, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Login – Please enter an email or phone number is not is not displayed in Spanish
What is the root cause of that problem?
translateis used here:Same issue is at multiple other places also.
What changes do you think we should make in order to solve the problem?
We need to remove translate:
And set it in the errorText:
Update at other string usages also (some in the same file and some in other files).
melvin-bot commentedon Jul 4, 2024
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Jul 4, 2024
@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Krishna2323 commentedon Jul 4, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Login – Please enter an email or phone number is not is not displayed in Spanish
What is the root cause of that problem?
translate is use when setting the form error.
App/src/pages/signin/LoginForm/BaseLoginForm.tsx
Lines 76 to 87 in 003d2fe
What changes do you think we should make in order to solve the problem?
Remove translate when updating formError and use it when passing the formError as
errorTextprop.We also need to update the type for formError state:
const [formError, setFormError] = useState<TranslationPaths | undefined>();We should also look up for other components which uses translate when setting the error text state.
What alternative solutions did you explore? (Optional)
ShridharGoel commentedon Jul 4, 2024
Proposal
Updated
Krishna2323 commentedon Jul 4, 2024
Proposal updated
melvin-bot commentedon Jul 8, 2024
Job added to Upwork: https://www.upwork.com/jobs/~015ecfe6dbe2a9cae6
[-]Login – Please enter an email or phone number is not is not displayed in Spanish[/-][+][$250] Login – Please enter an email or phone number is not is not displayed in Spanish[/+]melvin-bot commentedon Jul 8, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (
External)83 remaining items
muttmuure commentedon Aug 27, 2024
@Krishna2323 paid
muttmuure commentedon Aug 30, 2024
Waiting for @ShridharGoel to apply
muttmuure commentedon Sep 1, 2024
Dropping to weekly
muttmuure commentedon Sep 13, 2024
@ShridharGoel paid