You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD FOR PAYMENT 2024-07-15] Expense - Missing report title in report details page after the expense is paid #44959
Version Number: 9.0.5-3 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat with no unsettled expense
Submit an expense
Go to transaction thread
Pay the expense (same account as admin)
Click on the report header
Expected Result:
There will be report title in report details page after the expense is paid
Actual Result:
There is no report title in report details page after the expense is paid
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@srikarparsi FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Expense - Missing report title in report details page after the expense is paid[/-][+][HOLD FOR PAYMENT] Expense - Missing report title in report details page after the expense is paid[/+]on Jul 8, 2024
changed the title [-][HOLD FOR PAYMENT] Expense - Missing report title in report details page after the expense is paid[/-][+][HOLD FOR PAYMENT 2024-07-15] Expense - Missing report title in report details page after the expense is paid[/+]on Jul 11, 2024
Activity
melvin-bot commentedon Jul 8, 2024
Triggered auto assignment to @srikarparsi (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 8, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jul 8, 2024
@srikarparsi FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jul 8, 2024
We think that this bug might be related to #wave-collect - Release 1
ShridharGoel commentedon Jul 8, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense - Missing report title in report details page after the expense is paid.
What is the root cause of that problem?
In the existing logic, neither
nameSectionExpenseIOUis being shown nornameSectionTitleField.This is because
shouldShowTitleFieldis true andtitleFieldis undefined.App/src/pages/ReportDetailsPage.tsx
Lines 646 to 651 in e0ccba5
shouldShowTitleFieldbeing true dismisses the possibility of showingnameSectionExpenseIOU.titleFieldbeing undefined dismisses the possibility of showingnameSectionTitleField.What changes do you think we should make in order to solve the problem?
If titleField is not available, then we should show
nameSectionExpenseIOU.ShridharGoel commentedon Jul 8, 2024
@mountiny @srikarparsi I'm available to quickly open a PR to fix this.
Julesssss commentedon Jul 8, 2024
Thanks @ShridharGoel, I'm not familiar with this flow but your logic makes sense to me. Please go ahead and submit a PR
16 remaining items
[-]Expense - Missing report title in report details page after the expense is paid[/-][+][HOLD FOR PAYMENT] Expense - Missing report title in report details page after the expense is paid[/+]johncschuster commentedon Jul 10, 2024
@Julesssss just making sure I'm following along correctly – the PR that I should be watching for regressions is #44973, right?
Julesssss commentedon Jul 10, 2024
Hey @johncschuster. Yep that's correct 👍
johncschuster commentedon Jul 11, 2024
Thanks! Looks like it was approved on July 8, so I will pay this out on July 15 assuming no regressions 👍
[-][HOLD FOR PAYMENT] Expense - Missing report title in report details page after the expense is paid[/-][+][HOLD FOR PAYMENT 2024-07-15] Expense - Missing report title in report details page after the expense is paid[/+]johncschuster commentedon Jul 15, 2024
No regressions! I'll get this paid out today.
johncschuster commentedon Jul 15, 2024
Payment Summary:
Contributor+: @allroundexperts - $250 - paid via Manual request
Contributor: @ShridharGoel - $250 - paid via Upwork
johncschuster commentedon Jul 16, 2024
@ShridharGoel, can you accept the job linked above so I can issue payment?
johncschuster commentedon Jul 17, 2024
Bumped in Slack 👍
johncschuster commentedon Jul 19, 2024
Upwork job has not been accepted yet. Holding on that.
johncschuster commentedon Jul 22, 2024
Payment has been issued to @ShridharGoel! @allroundexperts, please request payment via ND if you haven't already done so.
JmillsExpensify commentedon Aug 21, 2024
$250 approved for @allroundexperts