Skip to content

[HOLD FOR PAYMENT 2024-07-15] Expense - Missing report title in report details page after the expense is paid #44959

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat with no unsettled expense
  3. Submit an expense
  4. Go to transaction thread
  5. Pay the expense (same account as admin)
  6. Click on the report header

Expected Result:

There will be report title in report details page after the expense is paid

Actual Result:

There is no report title in report details page after the expense is paid

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6535806_1720442348996.untitled.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mkhutornyi

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 8, 2024
  2. melvin-bot commented on Jul 8, 2024

    @melvin-bot

    Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jul 8, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jul 8, 2024

    @lanitochka17
    Author

    @srikarparsi FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. lanitochka17 commented on Jul 8, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-collect - Release 1

  6. ShridharGoel commented on Jul 8, 2024

    @ShridharGoel
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Expense - Missing report title in report details page after the expense is paid.

    What is the root cause of that problem?

    In the existing logic, neither nameSectionExpenseIOU is being shown nor nameSectionTitleField.

    This is because shouldShowTitleField is true and titleField is undefined.

    <View style={[styles.reportDetailsTitleContainer, styles.pb0]}>
    {renderedAvatar}
    {isExpenseReport && !shouldShowTitleField && nameSectionExpenseIOU}
    </View>
    {isExpenseReport && shouldShowTitleField && nameSectionTitleField}

    shouldShowTitleField being true dismisses the possibility of showing nameSectionExpenseIOU.

    titleField being undefined dismisses the possibility of showing nameSectionTitleField .

    What changes do you think we should make in order to solve the problem?

    If titleField is not available, then we should show nameSectionExpenseIOU.

    <View style={[styles.reportDetailsTitleContainer, styles.pb0]}>
        {renderedAvatar}
        {isExpenseReport && (!shouldShowTitleField || !titleField) && nameSectionExpenseIOU}
    </View>
    
    {isExpenseReport && shouldShowTitleField && titleField && nameSectionTitleField}
    
  7. ShridharGoel commented on Jul 8, 2024

    @ShridharGoel
    Contributor

    @mountiny @srikarparsi I'm available to quickly open a PR to fix this.

  8. Julesssss commented on Jul 8, 2024

    @Julesssss
    Contributor

    Thanks @ShridharGoel, I'm not familiar with this flow but your logic makes sense to me. Please go ahead and submit a PR

  9. removed
    DeployBlockerIndicates it should block deploying the API
    on Jul 8, 2024
  10. 16 remaining items

  11. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 8, 2024
  12. changed the title [-]Expense - Missing report title in report details page after the expense is paid[/-] [+][HOLD FOR PAYMENT] Expense - Missing report title in report details page after the expense is paid[/+] on Jul 8, 2024
  13. johncschuster commented on Jul 10, 2024

    @johncschuster
    Contributor

    @Julesssss just making sure I'm following along correctly – the PR that I should be watching for regressions is #44973, right?

  14. Julesssss commented on Jul 10, 2024

    @Julesssss
    Contributor

    Hey @johncschuster. Yep that's correct 👍

  15. johncschuster commented on Jul 11, 2024

    @johncschuster
    Contributor

    Thanks! Looks like it was approved on July 8, so I will pay this out on July 15 assuming no regressions 👍

  16. changed the title [-][HOLD FOR PAYMENT] Expense - Missing report title in report details page after the expense is paid[/-] [+][HOLD FOR PAYMENT 2024-07-15] Expense - Missing report title in report details page after the expense is paid[/+] on Jul 11, 2024
  17. johncschuster commented on Jul 15, 2024

    @johncschuster
    Contributor

    No regressions! I'll get this paid out today.

  18. johncschuster commented on Jul 15, 2024

    @johncschuster
    Contributor

    Payment Summary:

    Contributor+: @allroundexperts - $250 - paid via Manual request
    Contributor: @ShridharGoel - $250 - paid via Upwork

  19. johncschuster commented on Jul 16, 2024

    @johncschuster
    Contributor

    @ShridharGoel, can you accept the job linked above so I can issue payment?

  20. johncschuster commented on Jul 17, 2024

    @johncschuster
    Contributor

    Bumped in Slack 👍

  21. johncschuster commented on Jul 19, 2024

    @johncschuster
    Contributor

    Upwork job has not been accepted yet. Holding on that.

  22. johncschuster commented on Jul 22, 2024

    @johncschuster
    Contributor

    Payment has been issued to @ShridharGoel! @allroundexperts, please request payment via ND if you haven't already done so.

  23. JmillsExpensify commented on Aug 21, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions