Skip to content

[$250] Pay someone - Unapprove option is available for "Pay someone" expense, which gives error #44966

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.5-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any DM.
  3. Go to + > Pay someone.
  4. Enter amount and pay them.
  5. Click on the expense preview.
  6. Click on the report header..
  7. Click Unapprove.

Expected Result:

Unapprove option should not be available for "Pay someone" expense.

Actual Result:

Unapprove option is available for "Pay someone" expense, which results in error.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6535832_1720443170610.20240708_205102.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010702f689c6b7150e
  • Upwork Job ID: 1826736492231832841
  • Last Price Increase: 2024-08-22
Issue OwnerCurrent Issue Owner: @Pujan92

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 8, 2024
  2. melvin-bot commented on Jul 8, 2024

    @melvin-bot

    Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jul 8, 2024

    @melvin-bot

    Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Jul 8, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Jul 8, 2024

    @m-natarajan
    Author

    @johnmlee101 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. m-natarajan commented on Jul 8, 2024

    @m-natarajan
    Author

    We think that this bug might be related to #vip-vsb

  7. 23 remaining items

  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 22, 2024
  9. melvin-bot commented on Aug 22, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

  10. mallenexpensify commented on Aug 22, 2024

    @mallenexpensify
    Contributor

    ah.. shit, sorry @Pujan92 , forgot to assign @ishpaul777 BEFORE adding External.

    @ishpaul777 can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~010702f689c6b7150e

  11. ishpaul777 commented on Aug 23, 2024

    @ishpaul777
    Contributor

    I have accepted the offer 🙏 Thank you! @mallenexpensify

  12. removed their assignment
    on Aug 23, 2024
  13. mallenexpensify commented on Aug 26, 2024

    @mallenexpensify
    Contributor

    Contributor+: @ishpaul777 paid $250 via Upwork.

    @ishpaul777 we want a regression test for this, right? Assuming so, can you fill out the checklist? Thx

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@] The PR that introduced the bug has been identified. Link to the PR:
    • [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@] Determine if we should create a regression test for this bug.
    • [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@bz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. ishpaul777 commented on Aug 26, 2024

    @ishpaul777
    Contributor

    Regression Test proposal -

    • Open Newdot
    • Go to any DM.
    • Go to + > Pay someone.
    • Enter amount and pay them.
    • Click on the expense preview.
    • Click on the report header.

    Expected Result:

    Unapprove option should not be available for "Pay someone" expense report.

    Do we agree 👍 or 👎 ?

  15. mallenexpensify commented on Aug 26, 2024

    @mallenexpensify
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions