You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Pay someone - Unapprove option is available for "Pay someone" expense, which gives error #44966
Version Number: 9.0.5-2 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: n/a Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:
Action Performed:
Go to staging.new.expensify.com
Go to any DM.
Go to + > Pay someone.
Enter amount and pay them.
Click on the expense preview.
Click on the report header..
Click Unapprove.
Expected Result:
Unapprove option should not be available for "Pay someone" expense.
Actual Result:
Unapprove option is available for "Pay someone" expense, which results in error.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@johnmlee101 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
@ishpaul777 we want a regression test for this, right? Assuming so, can you fill out the checklist? Thx
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@] The PR that introduced the bug has been identified. Link to the PR:
[@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@] Determine if we should create a regression test for this bug.
[@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@bz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
[@ishpaul777] Determine if we should create a regression test for this bug. - Yes
Activity
melvin-bot commentedon Jul 8, 2024
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 8, 2024
Triggered auto assignment to @johnmlee101 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 8, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
m-natarajan commentedon Jul 8, 2024
@johnmlee101 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
m-natarajan commentedon Jul 8, 2024
We think that this bug might be related to #vip-vsb
23 remaining items
melvin-bot commentedon Aug 22, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (
External)mallenexpensify commentedon Aug 22, 2024
ah.. shit, sorry @Pujan92 , forgot to assign @ishpaul777 BEFORE adding
External.@ishpaul777 can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~010702f689c6b7150e
ishpaul777 commentedon Aug 23, 2024
I have accepted the offer 🙏 Thank you! @mallenexpensify
mallenexpensify commentedon Aug 26, 2024
Contributor+: @ishpaul777 paid $250 via Upwork.
@ishpaul777 we want a regression test for this, right? Assuming so, can you fill out the checklist? Thx
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
ishpaul777 commentedon Aug 26, 2024
Regression Test proposal -
Expected Result:
Unapprove option should not be available for "Pay someone" expense report.
Do we agree 👍 or 👎 ?
mallenexpensify commentedon Aug 26, 2024
Thanks @ishpaul777 test case GH created