Skip to content

[$250] Expense - Missing spacing between currency and amount in unapprove system message #44975

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • "Add approval" is enable in Workflow settings
  • Admin is the approver
  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Submit an expense
  4. Go to transaction thread
  5. Click Approve
  6. Click on the report header
  7. Click Unapprove

Expected Result:

The amount in the unapprove system message will have a space between the currency and amount

Actual Result:

The amount in the unapprove system message does not have a space between the currency and amount

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6535808_1720442351229.uv.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01791cd2da764f51cc
  • Upwork Job ID: 1810328690048713566
  • Last Price Increase: 2024-07-08
Issue OwnerCurrent Issue Owner: @ikevin127

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 8, 2024
  2. melvin-bot commented on Jul 8, 2024

    @melvin-bot

    Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jul 8, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jul 8, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-collect - Release 1

  5. lanitochka17 commented on Jul 8, 2024

    @lanitochka17
    Author

    @MariaHCD FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. MariaHCD commented on Jul 8, 2024

    @MariaHCD
    Contributor

    Not able to reproduce the issue on dev:

    Screenshot 2024-07-08 at 3 56 51 PM

    Will try with the MYR currency

  7. added and removed
    DeployBlockerIndicates it should block deploying the API
    on Jul 8, 2024
  8. 45 remaining items

  9. melvin-bot commented on Jul 22, 2024

    @melvin-bot

    @Beamanator Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  10. Beamanator commented on Jul 22, 2024

    @Beamanator
    Contributor

    Waiting for thoughts in slack

  11. Beamanator commented on Jul 25, 2024

    @Beamanator
    Contributor

    Merged!

  12. Beamanator commented on Jul 29, 2024

    @Beamanator
    Contributor

    Auth PR deployed 4 days ago (here) - let's retest this now 🙏

  13. moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collecton Jul 29, 2024
  14. Beamanator commented on Jul 30, 2024

    @Beamanator
    Contributor

    PR was deployed - @lanitochka17 can you please retest when you have a chance? 🙏

  15. Beamanator commented on Jul 31, 2024

    @Beamanator
    Contributor

    Spacing seems to be working well! Though the unapproved amount is broken maybe (my test was a bit old and weird since I was changing currencies a lot, so I'll try to reproduce and report that separately)? 😅

    [WIFI to slow to upload video ://///]

  16. moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collecton Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions