You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Expense - Missing spacing between currency and amount in unapprove system message #44975
Version Number: 9.0.5-3 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
"Add approval" is enable in Workflow settings
Admin is the approver
Go to staging.new.expensify.com
Go to workspace chat
Submit an expense
Go to transaction thread
Click Approve
Click on the report header
Click Unapprove
Expected Result:
The amount in the unapprove system message will have a space between the currency and amount
Actual Result:
The amount in the unapprove system message does not have a space between the currency and amount
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@MariaHCD FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Spacing seems to be working well! Though the unapproved amount is broken maybe (my test was a bit old and weird since I was changing currencies a lot, so I'll try to reproduce and report that separately)? 😅
Activity
melvin-bot commentedon Jul 8, 2024
Triggered auto assignment to @MariaHCD (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 8, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jul 8, 2024
We think that this bug might be related to #wave-collect - Release 1
lanitochka17 commentedon Jul 8, 2024
@MariaHCD FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
MariaHCD commentedon Jul 8, 2024
Not able to reproduce the issue on dev:
Will try with the MYR currency
45 remaining items
melvin-bot commentedon Jul 22, 2024
@Beamanator Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Beamanator commentedon Jul 22, 2024
Waiting for thoughts in slack
Beamanator commentedon Jul 25, 2024
Merged!
Beamanator commentedon Jul 29, 2024
Auth PR deployed 4 days ago (here) - let's retest this now 🙏
Beamanator commentedon Jul 30, 2024
PR was deployed - @lanitochka17 can you please retest when you have a chance? 🙏
Beamanator commentedon Jul 31, 2024
Spacing seems to be working well! Though the unapproved amount is broken maybe (my test was a bit old and weird since I was changing currencies a lot, so I'll try to reproduce and report that separately)? 😅
[WIFI to slow to upload video ://///]