You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - "Unapprove" option is available in report with deleted expense that has comments #44991
Version Number: 9.0.5-4 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
[User A] Submit two expenses to User B
[User A] Go to transaction thread of one of the expenses, and add some comments
[User A] Delete the expense that has comments
[User B] Go to DM with User A
{User B] Click on the expense preview
[User B] Pay the report
[User B] Go to the report that has comments (expense deleted)
[User B] Click on the report header
Expected Result:
"Unapprove" option should not appear since the expense is deleted, only comments are left in the report
Actual Result:
"Unapprove" options shows up even though the expense is deleted
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@blimpich FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Activity
melvin-bot commentedon Jul 8, 2024
Triggered auto assignment to @blimpich (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 8, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jul 8, 2024
@blimpich FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jul 8, 2024
We think that this bug might be related to #wave-collect - Release 1
blimpich commentedon Jul 8, 2024
Looking into this now
blimpich commentedon Jul 8, 2024
Think I know what caused this, testing locally.
blimpich commentedon Jul 8, 2024
Having trouble repro-ing locally.
blimpich commentedon Jul 8, 2024
Was able to repro and confirm it stems from this PR
cc: @rushatgabhane @Beamanator
blimpich commentedon Jul 8, 2024
Demoting because this is edge case.
1 remaining item
blimpich commentedon Jul 8, 2024
@Beamanator @rushatgabhane assigned both of you as this is follow up for this PR you worked on recently.
rushatgabhane commentedon Jul 8, 2024
cool cool we have to check for deleted report here
https://github.com/Expensify/App/pull/44229/files#diff-409b0e2fb439856e9897b808014031ce244a427d116ed30f37a2e0117599adc4R202
garrettmknight commentedon Jul 9, 2024
@rushatgabhane I don't think we should be showing Unapprove at the expense level to begin with.
Beamanator commentedon Jul 9, 2024
True, I'm removing the Unapprove button from showing at the expense level in #45049, as that also fixes #44969
Beamanator commentedon Jul 9, 2024
Fix merged & CPing
melvin-bot commentedon Jul 12, 2024
@Beamanator, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!
Beamanator commentedon Jul 12, 2024
This should be fixed already