You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-24] [$250] “Book a call” option is not there in Concierge. #45036
The isConcierge condition is false. Because in the Concierge report, there are two participants (the current user and concierge), participantAccountIDs.length will be 2
@ShridharGoel yeah you have first dibs, however, can you please also link what caused this regression? Either the isConciergeChatReport is not used for anything very important or its been messing around with stuff for a while now
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
[@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@jayeshmangwani] Determine if we should create a regression test for this bug.
[@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@jayeshmangwani] Determine if we should create a regression test for this bug. Yes
[@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Jul 9, 2024
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Jul 9, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
“Book a call” option is not there.
What is the root cause of that problem?
App/src/pages/ProfilePage.tsx
Lines 285 to 288 in 7b558ef
The
isConciergecondition is false. Because in the Concierge report, there are two participants (the current user and concierge), participantAccountIDs.length will be 2App/src/libs/ReportUtils.ts
Lines 1046 to 1049 in 7b558ef
What changes do you think we should make in order to solve the problem?
I think it make sense to update
participantAccountIDs.length === 2and add the condition to verify the second participant is the current userWhat alternative solutions did you explore? (Optional)
NA
ShridharGoel commentedon Jul 9, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Book a call" option is not present in Concierge profile page.
What is the root cause of that problem?
isConciergecondition becomes false because of flawed logic inisConciergeChatReportApp/src/pages/ProfilePage.tsx
Line 182 in dd96852
App/src/pages/ProfilePage.tsx
Lines 285 to 292 in dd96852
The below would always return false since report.participants will also have the logged in user.
App/src/libs/ReportUtils.ts
Lines 1046 to 1049 in dd96852
This would also lead to other bugs.
What changes do you think we should make in order to solve the problem?
Update the logic to this to filter out the logged in user before checking the number of participants and matching the ID of the one at 0th index.
ShridharGoel commentedon Jul 9, 2024
@mountiny Would I be having the first dibs based on the Slack conversation about this issue?
melvin-bot commentedon Jul 9, 2024
Job added to Upwork: https://www.upwork.com/jobs/~014b054cf89e8b9e03
[-]“Book a call” option is not there in Concierge.[/-][+][$250] “Book a call” option is not there in Concierge.[/+]melvin-bot commentedon Jul 9, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)mountiny commentedon Jul 9, 2024
@ShridharGoel yeah you have first dibs, however, can you please also link what caused this regression? Either the
isConciergeChatReportis not used for anything very important or its been messing around with stuff for a while now27 remaining items
melvin-bot commentedon Jul 17, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-24. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 17, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
jayeshmangwani commentedon Jul 17, 2024
Regression Test Proposal
Do we agree 👍 or 👎
JmillsExpensify commentedon Jul 26, 2024
Payment summary:
JmillsExpensify commentedon Jul 26, 2024
Contributor paid via Upwork and regression test created. Closing this issue! @jayeshmangwani please submit an expense via NewDot.
jayeshmangwani commentedon Aug 5, 2024
Requested as per #45036 (comment)
mallenexpensify commentedon Aug 6, 2024
Contributor: @ShridharGoel paid $250 via Upwork
Reviewer: @jayeshmangwani owed $250 via NewDot
JmillsExpensify commentedon Aug 6, 2024
$250 approved for @jayeshmangwani