Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4700894&group_by=cases:section_id&group_id=309128&group_order=asc
Email or phone of affected tester (no customers): gocemate+workspaceapprover135@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
Preconditions:
- Login as the owner of the workspace
- Create a workspace
- Invite the approver and employee
- Navigate to more features
- Enable "workflows"
- On the "Workflow" editor - enable "Add Approvals"
- Set the Approver account as the Approver
Steps: - As Employee submit 2 expenses to Workspace chat
- As Approver hold the first expense
- As Approver go back to the expenses page ( there is red dot on the expense that is on Hold)
- As Approver go back to transaction thread> Unhold the expense
- As Approver go back to expenses page
Expected Result:
There should be no red dot on the unheld expense
Actual Result:
Red dot remains when approver unhold expense
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6536079_1720455823531.Recording__3457.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01785e48b0c37e8c52
- Upwork Job ID: 1810949376048189607
- Last Price Increase: 2024-07-10
- Automatic offers:
- paultsimura | Reviewer | 103143168
Activity
melvin-bot commentedon Jul 9, 2024
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Jul 9, 2024
@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
bernhardoj commentedon Jul 9, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The hold status isn't removed immediately from the money request preview.
What is the root cause of that problem?
The hold status comes from the
transaction.comment.holdstatus or the transaction violations.App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx
Line 111 in bb9b486
App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx
Line 130 in bb9b486
When we hold, the
transaction.comment.holdis set, but the transaction violations are still empty. After we reopen the transaction thread, the transaction violations are returned from the BE. When we unhold the request, we only optimistically remove thetransaction.comment.hold.App/src/libs/actions/IOU.ts
Lines 7041 to 7059 in bb9b486
So, the transaction violations (that contain hold violations) still exist, thus the money request preview still shows the hold status. Reopening the transaction thread once again will clear it.
What changes do you think we should make in order to solve the problem?
Optimistically removes the transaction violations of hold when unhold-ing a request. (and revert it when fails)
I also suggest to return the onyx update to clears the hold violation from the UnholdRequest API.
(we can also optimistically add the hold violation if needed, lmk if we should do it)
dylanexpensify commentedon Jul 10, 2024
moving!
[-] Hold - Red dot remains when unhold expense[/-][+][$250] Hold - Red dot remains when unhold expense[/+]melvin-bot commentedon Jul 10, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01785e48b0c37e8c52
melvin-bot commentedon Jul 10, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (
External)paultsimura commentedon Jul 10, 2024
Reviewing today 👀
paultsimura commentedon Jul 11, 2024
The proposal by @bernhardoj looks good to me.
🎀👀🎀 C+ reviewed
@cead22 sorry if you're the wrong person, but IIRC you were implementing the violations initially. We should modify the BE to remove the
holdviolation on theUnholdRequestAPI endpoint (in addition to the App changes). Could you please check it?22 remaining items
melvin-bot commentedon Jul 19, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
dylanexpensify commentedon Jul 22, 2024
Payment coming up!
paultsimura commentedon Jul 22, 2024
Regression Test Proposal
Do we agree 👍 or 👎
melvin-bot commentedon Jul 25, 2024
Triggered auto assignment to @OfstadC (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.dylanexpensify commentedon Jul 25, 2024
@OfstadC I'm heading OOO starting this afternoon, so reassigning for payment! TY!
bernhardoj commentedon Jul 26, 2024
Payment is due today. Requested in ND.
OfstadC commentedon Jul 26, 2024
Payment Summary:
@paultsimura paid $250 via Upwork
@bernhardoj due $250 via NewDot
JmillsExpensify commentedon Jul 26, 2024
$250 approved for @bernhardoj