Skip to content

[Awaiting Payment 9th August] [$250] Accounting - Accounting isn't enabled in ND if a connection is made in OD #45080

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #44743

Action Performed:

Precondition: Have a workspace in OD with a connection to QBO or Netsuite. Haven't logged in to ND yet.

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with an account that has a workspace in OD
  3. Navigate to Workspace settings - More features
  4. Enable "Accounting"

Expected Result:

Accounting should be enabled

Actual Result:

Accounting isn't enabled in ND if a connection is made in OD. The connection is visible when Accounting is enabled

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

20240709_195018.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019e7910738bf73906
  • Upwork Job ID: 1811348357918542670
  • Last Price Increase: 2024-07-11
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 9, 2024
  2. melvin-bot commented on Jul 9, 2024

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. trjExpensify commented on Jul 10, 2024

    @trjExpensify
    Contributor

    👋 @hayata-suenaga @aldo-expensify @lakchote! Can I get an opinion on whether this is FE or BE?

  4. lakchote commented on Jul 11, 2024

    @lakchote
    Contributor

    👋 @hayata-suenaga @aldo-expensify @lakchote! Can I get an opinion on whether this is FE or BE?

    I'd say this is FE.

    const hasAccountingConnection = !!policy?.areConnectionsEnabled && !isEmptyObject(policy?.connections);

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 11, 2024
  6. changed the title [-]Accounting - Accounting isn't enabled in ND if a connection is made in OD[/-] [+][$250] Accounting - Accounting isn't enabled in ND if a connection is made in OD[/+] on Jul 11, 2024
  7. melvin-bot commented on Jul 11, 2024

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 11, 2024
  9. melvin-bot commented on Jul 11, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

  10. trjExpensify commented on Jul 11, 2024

    @trjExpensify
    Contributor

    Cool, moving it on external.

  11. 27 remaining items

  12. changed the title [-][$250] Accounting - Accounting isn't enabled in ND if a connection is made in OD[/-] [+][Awaiting Payment 9th August] [$250] Accounting - Accounting isn't enabled in ND if a connection is made in OD[/+] on Aug 2, 2024
  13. trjExpensify commented on Aug 2, 2024

    @trjExpensify
    Contributor

    Looks like the automation failed, so I'll update this issue to note the regression period has started and I've hired you in Upwork. Payment will be issued 7 days from the prod deploy, if there aren't any regressions.

    image
  14. NJ-2020 commented on Aug 2, 2024

    @NJ-2020
    Contributor

    @trjExpensify Thank you

  15. trjExpensify commented on Aug 2, 2024

    @trjExpensify
    Contributor

    NP!

  16. carlosmiceli commented on Aug 2, 2024

    @carlosmiceli
    Contributor

    Remove overdue, Melvin

  17. trjExpensify commented on Aug 5, 2024

    @trjExpensify
    Contributor

    Payment due on the 9th, Melvin.

  18. melvin-bot commented on Aug 6, 2024

    @melvin-bot

    @carlosmiceli @trjExpensify @mollfpr @NJ-2020 this issue is now 4 weeks old, please consider:

    • Finding a contributor to fix the bug
    • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
    • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

    Thanks!

  19. mollfpr commented on Aug 7, 2024

    @mollfpr
    Contributor

    [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
    [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    No offending PR was found.

    [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    The regression step should be enough.

    [@mollfpr] Determine if we should create a regression test for this bug.
    [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    1. Create a new workspace in ND or use any workspace that doesn't have the Accounting feature enabled
    2. Go to OD select the workspace, go to the Connections tab, click Connect to Quickbooks
    3. Go back to New Dot and open the More features page
    4. Verify the Accounting feature is enabled and the connection to Quickbooks is a success
    5. 👍 or 👎
  20. trjExpensify commented on Aug 9, 2024

    @trjExpensify
    Contributor

    Thanks! Payment summary as follows:

    • $250 to @mollfpr for the C+ review (go ahead and request!)
    • $250 to @NJ-2020 for the bug fix (paid)

    Regression test issue created. Closing!

  21. JmillsExpensify commented on Aug 12, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @mollfpr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions