You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Awaiting Payment 9th August] [$250] Accounting - Accounting isn't enabled in ND if a connection is made in OD #45080
Version Number: 9.0.5-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
changed the title [-]Accounting - Accounting isn't enabled in ND if a connection is made in OD[/-][+][$250] Accounting - Accounting isn't enabled in ND if a connection is made in OD[/+]on Jul 11, 2024
changed the title [-][$250] Accounting - Accounting isn't enabled in ND if a connection is made in OD[/-][+][Awaiting Payment 9th August] [$250] Accounting - Accounting isn't enabled in ND if a connection is made in OD[/+]on Aug 2, 2024
Looks like the automation failed, so I'll update this issue to note the regression period has started and I've hired you in Upwork. Payment will be issued 7 days from the prod deploy, if there aren't any regressions.
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
No offending PR was found.
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
The regression step should be enough.
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Create a new workspace in ND or use any workspace that doesn't have the Accounting feature enabled
Go to OD select the workspace, go to the Connections tab, click Connect to Quickbooks
Go back to New Dot and open the More features page
Verify the Accounting feature is enabled and the connection to Quickbooks is a success
Activity
melvin-bot commentedon Jul 9, 2024
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.trjExpensify commentedon Jul 10, 2024
👋 @hayata-suenaga @aldo-expensify @lakchote! Can I get an opinion on whether this is FE or BE?
lakchote commentedon Jul 11, 2024
I'd say this is FE.
App/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx
Line 87 in a19ef98
[-]Accounting - Accounting isn't enabled in ND if a connection is made in OD[/-][+][$250] Accounting - Accounting isn't enabled in ND if a connection is made in OD[/+]melvin-bot commentedon Jul 11, 2024
Job added to Upwork: https://www.upwork.com/jobs/~019e7910738bf73906
melvin-bot commentedon Jul 11, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)trjExpensify commentedon Jul 11, 2024
Cool, moving it on external.
27 remaining items
[-][$250] Accounting - Accounting isn't enabled in ND if a connection is made in OD[/-][+][Awaiting Payment 9th August] [$250] Accounting - Accounting isn't enabled in ND if a connection is made in OD[/+]trjExpensify commentedon Aug 2, 2024
Looks like the automation failed, so I'll update this issue to note the regression period has started and I've hired you in Upwork. Payment will be issued 7 days from the prod deploy, if there aren't any regressions.
NJ-2020 commentedon Aug 2, 2024
@trjExpensify Thank you
trjExpensify commentedon Aug 2, 2024
NP!
carlosmiceli commentedon Aug 2, 2024
Remove overdue, Melvin
trjExpensify commentedon Aug 5, 2024
Payment due on the 9th, Melvin.
melvin-bot commentedon Aug 6, 2024
@carlosmiceli @trjExpensify @mollfpr @NJ-2020 this issue is now 4 weeks old, please consider:
Thanks!
mollfpr commentedon Aug 7, 2024
No offending PR was found.
The regression step should be enough.
trjExpensify commentedon Aug 9, 2024
Thanks! Payment summary as follows:
Regression test issue created. Closing!
JmillsExpensify commentedon Aug 12, 2024
$250 approved for @mollfpr