You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Report fields - All report fields disappear instead of crossed out when deleted offline #45159
Version Number: 9.0.6-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - internal Team
Action Performed:
Go to staging.new.expensify.com
Go to workspace settings > Report fields
Add a few report fields
Go offline
Delete all the report fields
Expected Result:
The report fields should be crossed out when all the report fields are deleted offline (production behavior)
Actual Result:
The report field list is empty when all the report fields are deleted offline
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@AndrewGable FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
What changes do you think we should make in order to solve the problem?
We should check if the network is offline, we will not show the empty state if we have pending delete report fields as we do in other pages like category pages here
Activity
melvin-bot commentedon Jul 10, 2024
Triggered auto assignment to @AndrewGable (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 10, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jul 10, 2024
@AndrewGable FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
nkdengineer commentedon Jul 10, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The report field list is empty when all the report fields are deleted offline
What is the root cause of that problem?
We show the empty state if all report fields has
pendingActionis deletedApp/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx
Lines 130 to 132 in 97b3831
What changes do you think we should make in order to solve the problem?
We should check if the network is offline, we will not show the empty state if we have pending delete report fields as we do in other pages like category pages here
App/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx
Lines 130 to 132 in 97b3831
What alternative solutions did you explore? (Optional)
rushatgabhane commentedon Jul 17, 2024
PR reviewed