You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-01] Accounting - Non-reimbursable and Reimbursable expense options don't get auto focused #45192
Version Number: 9.0.6-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Accounting - Non-reimbursable and Reimbursable expense options don't get auto focused[/-][+][HOLD for payment 2024-08-01] Accounting - Non-reimbursable and Reimbursable expense options don't get auto focused[/+]on Jul 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
Activity
melvin-bot commentedon Jul 10, 2024
Triggered auto assignment to @stitesExpensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 10, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jul 10, 2024
@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jul 10, 2024
We think that this bug might be related to #wave-collect - Release 1
neonbhai commentedon Jul 10, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Accounting - Non-reimbursable and Reimbursable expense options don't get auto focused
What is the root cause of that problem?
NetSuitCustomFormIDPageis missing logic to autofocus the TextInput hereWhat changes do you think we should make in order to solve the problem?
We will use
useAutoFocusInputto configure autofocus onNetSuitCustomFormIDPagehere:App/src/pages/workspace/accounting/netsuite/advanced/NetSuiteCustomFormIDPage.tsx
Lines 83 to 92 in 98932a2
Alternatively
We may use
useFocusEffect()to focus the TextInput.stitesExpensify commentedon Jul 10, 2024
Posted here, I think that this is a direct result of this PR #44921
mananjadhav commentedon Jul 10, 2024
Yes. @shubham1206agra and I will take care of this. You can assign this to us. Also this is behind beta so not a deploy blocker.
cc - @yuwenmemon
12 remaining items
mananjadhav commentedon Jul 16, 2024
The PR is up and I've also added the fix to the Token Input page.
[-]Accounting - Non-reimbursable and Reimbursable expense options don't get auto focused[/-][+][HOLD for payment 2024-08-01] Accounting - Non-reimbursable and Reimbursable expense options don't get auto focused[/+]melvin-bot commentedon Jul 25, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-01. 🎊
For reference, here are some details about the assignees on this issue:
mananjadhav commentedon Jul 31, 2024
We can close this one out. The payout will be done centrally.
melvin-bot commentedon Aug 1, 2024
Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Aug 1, 2024
Payment Summary
Upwork Job
BugZero Checklist (@twisterdotcom)